paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

activity: Fix buddy_list unread count not being updated instantly.

Browse Source 
While rest of the app has ported to the new system of updating
unread_counts `activity` was not ported. This resulted in
unread count in buddy list not being updated when new
PMs arrive.
This commit is contained in:
Aman Agrawal
2021-04-15 06:43:09 +00:00
committed by Tim Abbott
parent 06af1715cb
commit e5acbf9498
2 changed files with 7 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
frontend_tests/node_tests/activity.js
View File

@@ -261,13 +261,11 @@ function buddy_list_add(user_id, stub) {
}
test_ui("PM_update_dom_counts", () => {
const value = $.create("alice-value");
const count = $.create("alice-count");
const count = $.create("alice-unread-count");
const pm_key = alice.user_id.toString();
const li = $.create("alice stub");
buddy_list_add(pm_key, li);
count.set_find_results(".value", value);
li.set_find_results(".count", count);
li.set_find_results(".unread_count", count);
count.set_parents_result("li", li);
const counts = new Map();
@@ -275,14 +273,12 @@ test_ui("PM_update_dom_counts", () => {
li.addClass("user_sidebar_entry");
activity.update_dom_with_unread_counts({pm_count: counts});
assert(li.hasClass("user-with-count"));
assert.equal(value.text(), "5");
assert.equal(count.text(), "5");
counts.set(pm_key, 0);
activity.update_dom_with_unread_counts({pm_count: counts});
assert(!li.hasClass("user-with-count"));
assert.equal(value.text(), "");
assert.equal(count.text(), "");
});
test_ui("handlers", (override) => {