paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

typeahead: Update characters allowed before @-mentions.

Browse Source 
Now the following characters are allowed before @-mentions, stream
references (starting with #) and emojis (starting with :) - space, (,
{, [, ", ', /, <.

Earlier only the opening brace type characters and space was allowed.
This commit is contained in:
N-Shar-ma
2022-04-13 21:30:58 +05:30
committed by Tim Abbott
parent 5ad515c560
commit e671decd29
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
frontend_tests/node_tests/composebox_typeahead.js
View File

@@ -1424,6 +1424,12 @@ test("tokenizing", () => {
assert.equal(ct.tokenize_compose_str("foo bar"), ""); assert.equal(ct.tokenize_compose_str("foo bar"), "");
assert.equal(ct.tokenize_compose_str("foo#@:bar"), ""); assert.equal(ct.tokenize_compose_str("foo#@:bar"), "");
assert.equal(ct.tokenize_compose_str("foo bar [#alic"), "#alic"); assert.equal(ct.tokenize_compose_str("foo bar [#alic"), "#alic");
assert.equal(ct.tokenize_compose_str("foo bar (#alic"), "#alic");
assert.equal(ct.tokenize_compose_str("foo bar {#alic"), "#alic");
assert.equal(ct.tokenize_compose_str("foo bar /#alic"), "#alic");
assert.equal(ct.tokenize_compose_str("foo bar <#alic"), "#alic");
assert.equal(ct.tokenize_compose_str("foo bar '#alic"), "#alic");
assert.equal(ct.tokenize_compose_str('foo bar "#alic'), "#alic");
assert.equal(ct.tokenize_compose_str("#foo @bar [#alic"), "#alic"); assert.equal(ct.tokenize_compose_str("#foo @bar [#alic"), "#alic");
assert.equal(ct.tokenize_compose_str("foo bar #alic"), "#alic"); assert.equal(ct.tokenize_compose_str("foo bar #alic"), "#alic");
assert.equal(ct.tokenize_compose_str("foo bar @alic"), "@alic"); assert.equal(ct.tokenize_compose_str("foo bar @alic"), "@alic");

2
static/js/composebox_typeahead.js
View File

@@ -309,7 +309,7 @@ export function tokenize_compose_str(s) {
case "_": case "_":
if (i === 0) { if (i === 0) {
return s; return s;
} else if (/[\s()[\]{}]/.test(s[i - 1])) { } else if (/[\s"'(/<[{]/.test(s[i - 1])) {
return s.slice(i); return s.slice(i);
} }
break; break;