paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-08 16:01:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Hide upgrade links and storage stats for guests.

Browse Source 
Avoids displaying the upgrade banner in upgrade_tip_widget.hbs and attachments stats banner in 'Uploaded files' UI when the user is logged in as a guest. This ensures that guest users do not see upgrade-related links that do not apply to them and cause 404 errors.

Fixes #20630.
This commit is contained in:
Anushrut pandit
2025-01-25 21:59:28 +05:30
committed by Tim Abbott
parent ee3660ae19
commit e67786154a
2 changed files with 20 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
web/src/attachments_ui.ts
View File

@@ -13,7 +13,7 @@ import {$t, $t_html} from "./i18n.ts";
import * as ListWidget from "./list_widget.ts"; import * as ListWidget from "./list_widget.ts";
import * as loading from "./loading.ts"; import * as loading from "./loading.ts";
import * as scroll_util from "./scroll_util.ts"; import * as scroll_util from "./scroll_util.ts";
import {realm} from "./state_data.ts"; import {current_user, realm} from "./state_data.ts";
import * as timerender from "./timerender.ts"; import * as timerender from "./timerender.ts";
import * as ui_report from "./ui_report.ts"; import * as ui_report from "./ui_report.ts";
@@ -68,6 +68,9 @@ function set_upload_space_stats(): void {
if (realm.realm_upload_quota_mib === null) { if (realm.realm_upload_quota_mib === null) {
return; return;
} }
if (current_user.is_guest) {
return;
}
const args = { const args = {
show_upgrade_message: realm.realm_plan_type === 2, show_upgrade_message: realm.realm_plan_type === 2,
upload_quota_string: $t( upload_quota_string: $t(

30
web/templates/settings/upgrade_tip_widget.hbs
View File

@@ -1,17 +1,19 @@
<div> <div>
{{#unless zulip_plan_is_not_limited}} {{#unless is_guest}}
{{#if is_business_type_org}} {{#unless zulip_plan_is_not_limited}}
<a href="/upgrade/" class="upgrade-tip" target="_blank" rel="noopener noreferrer"> {{#if is_business_type_org}}
{{upgrade_text_for_wide_organization_logo}} <a href="/upgrade/" class="upgrade-tip" target="_blank" rel="noopener noreferrer">
</a> {{upgrade_text_for_wide_organization_logo}}
{{else}} </a>
<div class="upgrade-or-sponsorship-tip"> {{else}}
{{#tr}} <div class="upgrade-or-sponsorship-tip">
Available on Zulip Cloud Standard. <z-link-upgrade>Upgrade</z-link-upgrade> or <z-link-sponsorship>request sponsorship</z-link-sponsorship> to access. {{#tr}}
{{#*inline "z-link-upgrade"}}<a href="/upgrade/" target="_blank" rel="noopener noreferrer">{{> @partial-block}}</a>{{/inline}} Available on Zulip Cloud Standard. <z-link-upgrade>Upgrade</z-link-upgrade> or <z-link-sponsorship>request sponsorship</z-link-sponsorship> to access.
{{#*inline "z-link-sponsorship"}}<a href="/sponsorship/" target="_blank" rel="noopener noreferrer">{{> @partial-block}}</a>{{/inline}} {{#*inline "z-link-upgrade"}}<a href="/upgrade/" target="_blank" rel="noopener noreferrer">{{> @partial-block}}</a>{{/inline}}
{{/tr}} {{#*inline "z-link-sponsorship"}}<a href="/sponsorship/" target="_blank" rel="noopener noreferrer">{{> @partial-block}}</a>{{/inline}}
</div> {{/tr}}
{{/if}} </div>
{{/if}}
{{/unless}}
{{/unless}} {{/unless}}
</div> </div>