paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

user popover: Don't throw an exception for deactivated target users.

Browse Source 
Ideally, we'd fix this at the root cause, via #4322, but this will at
least suppress the exception for now.
This commit is contained in:
Tim Abbott
2017-08-27 16:40:34 -07:00
parent 3e1bf86ced
commit e68de7ac8d
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
static/js/popovers.js
View File

@@ -55,7 +55,16 @@ function user_last_seen_time_status(user_id) {
// We don't send presence data to clients in Zephyr mirroring realms
return i18n.t("Unknown");
}
return timerender.last_seen_status_from_date(presence.last_active_date(user_id).clone());
// TODO: If the user account has been deactivated, it won't appear
// in the presence data set. Ideally, we'd have a cleaner
// solution that had us understand that state declaratively and
// thus not need this check (see #4322).
var last_active_date = presence.last_active_date(user_id);
if (last_active_date === undefined) {
return i18n.t("Unknown");
}
return timerender.last_seen_status_from_date(last_active_date.clone());
}
function show_message_info_popover(element, id) {