paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Move insert_message to echo.

Browse Source 
This change does not impact the overall complexity
of our dependency graph (at least in terms of the
number of edges that we would need to remove to get
a tree), but it does clarify the picture a bit.
This commit is contained in:
Steve Howell
2021-03-26 13:39:40 +00:00
committed by Tim Abbott
parent 1585c2a12c
commit e72f208fde
4 changed files with 13 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
frontend_tests/node_tests/compose.js
View File

@@ -48,7 +48,6 @@ const _document = {
set_global("document", _document);
const channel = mock_esm("../../static/js/channel");
const loading = mock_esm("../../static/js/loading");
const local_message = mock_esm("../../static/js/local_message");
const markdown = mock_esm("../../static/js/markdown");
const reminder = mock_esm("../../static/js/reminder", {
is_deferred_delivery: noop,
@@ -724,9 +723,9 @@ test_ui("send_message", (override) => {
override(compose_state, "private_message_recipient", () => "alice@example.com");
const server_message_id = 127;
local_message.insert_message = (message) => {
override(echo, "insert_message", (message) => {
assert.equal(message.timestamp, fake_now);
};
});
markdown.apply_markdown = () => {};
markdown.add_topic_links = () => {};

5
frontend_tests/node_tests/echo.js
View File

@@ -8,7 +8,6 @@ const {mock_esm, set_global, zrequire} = require("../zjsunit/namespace");
const {run_test} = require("../zjsunit/test");
const {page_params} = require("../zjsunit/zpage_params");
const local_message = mock_esm("../../static/js/local_message");
const markdown = mock_esm("../../static/js/markdown");
let disparities = [];
@@ -188,7 +187,7 @@ run_test("insert_local_message streams", (override) => {
add_topic_links_called = true;
});
override(local_message, "insert_message", (message) => {
override(echo, "insert_message", (message) => {
assert.equal(message.display_recipient, "general");
assert.equal(message.timestamp, fake_now);
assert.equal(message.sender_email, "iago@zulip.com");
@@ -232,7 +231,7 @@ run_test("insert_local_message PM", (override) => {
let apply_markdown_called = false;
let insert_message_called = false;
override(local_message, "insert_message", (message) => {
override(echo, "insert_message", (message) => {
assert.equal(message.display_recipient.length, 3);
insert_message_called = true;
});