paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-13 10:26:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

stripe: Fix exception handler for suppressed events.

Browse Source 
Apparently, we incorrectly placed the try/except block around the
common code, not the code that can actually raise these exceptions.
This commit is contained in:
Tim Abbott
2018-12-13 10:22:19 -08:00
parent 76c6cf8c3a
commit e7746809d2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
zerver/webhooks/stripe/view.py
View File

@@ -25,13 +25,13 @@ class SuppressedEvent(Exception):
def api_stripe_webhook(request: HttpRequest, user_profile: UserProfile, def api_stripe_webhook(request: HttpRequest, user_profile: UserProfile,
payload: Dict[str, Any]=REQ(argument_type='body'), payload: Dict[str, Any]=REQ(argument_type='body'),
stream: str=REQ(default='test')) -> HttpResponse: stream: str=REQ(default='test')) -> HttpResponse:
topic, body = topic_and_body(payload)
try: try:
check_send_webhook_message(request, user_profile, topic, body) topic, body = topic_and_body(payload)
except NotImplementedEventType: # nocoverage except NotImplementedEventType: # nocoverage
pass pass
except SuppressedEvent: # nocoverage except SuppressedEvent: # nocoverage
pass pass
check_send_webhook_message(request, user_profile, topic, body)
return json_success() return json_success()
def topic_and_body(payload: Dict[str, Any]) -> Tuple[str, str]: def topic_and_body(payload: Dict[str, Any]) -> Tuple[str, str]: