paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-10 00:46:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

search_suggestion: Convert huddle_dict from object to Map.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2020-02-11 22:05:22 -08:00
committed by Tim Abbott
parent 7c6ec51e5d
commit e848bc2a21
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
static/js/search_suggestion.js
View File

@@ -52,9 +52,9 @@ function compare_by_huddle(huddle) {
// Construct dict for all huddles, so we can lookup each's recency // Construct dict for all huddles, so we can lookup each's recency
const huddles = activity.get_huddles(); const huddles = activity.get_huddles();
const huddle_dict = {}; const huddle_dict = new Map();
for (let i = 0; i < huddles.length; i += 1) { for (const [i, huddle] of huddles.entries()) {
huddle_dict[huddles[i]] = i + 1; huddle_dict.set(huddle, i + 1);
} }
return function (person1, person2) { return function (person1, person2) {
@@ -62,8 +62,8 @@ function compare_by_huddle(huddle) {
const huddle2 = huddle.concat(person2.user_id).sort().join(','); const huddle2 = huddle.concat(person2.user_id).sort().join(',');
// If not in the dict, assign an arbitrarily high index // If not in the dict, assign an arbitrarily high index
const score1 = huddle_dict[huddle1] || 100; const score1 = huddle_dict.get(huddle1) || huddles.length + 1;
const score2 = huddle_dict[huddle2] || 100; const score2 = huddle_dict.get(huddle2) || huddles.length + 1;
const diff = score1 - score2; const diff = score1 - score2;
if (diff !== 0) { if (diff !== 0) {