From e916abf31e76d34309309c6beda8ffe48152dac0 Mon Sep 17 00:00:00 2001 From: Anders Kaseorg Date: Mon, 7 Apr 2025 18:56:32 -0700 Subject: [PATCH] worker: Check if Sentry is initialized before calling add_breadcrumb. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Otherwise we get spammed with “Dropped breadcrumb because no client bound” log messages. Signed-off-by: Anders Kaseorg (cherry picked from commit e8faa4a0299757c65b521f34f906fbf70019abf7) --- zerver/worker/base.py | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/zerver/worker/base.py b/zerver/worker/base.py index 0e2a95a4f7..ab69cc6771 100644 --- a/zerver/worker/base.py +++ b/zerver/worker/base.py @@ -173,12 +173,16 @@ class QueueProcessingWorker(ABC): name=f"consume {self.queue_name}", custom_sampling_context={"queue": self.queue_name}, ): - sentry_sdk.add_breadcrumb( - type="debug", - category="queue_processor", - message=f"Consuming {self.queue_name}", - data={"events": events, "local_queue_size": self.get_remaining_local_queue_size()}, - ) + if sentry_sdk.is_initialized(): + sentry_sdk.add_breadcrumb( + type="debug", + category="queue_processor", + message=f"Consuming {self.queue_name}", + data={ + "events": events, + "local_queue_size": self.get_remaining_local_queue_size(), + }, + ) try: if self.idle: # We're reactivating after having gone idle due to emptying the queue.