paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

user_groups: Add API restrictions for long user group names.

Browse Source 
Previously we had database level restriction on length of
user group names. Now we add the same restriction to API
level as well, so we can return a better error response.
This commit is contained in:
Sahil Batra
2023-07-03 11:31:01 +05:30
committed by Tim Abbott
parent 89381a8072
commit ea3a7a9e6f
4 changed files with 29 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zerver/views/user_groups.py
View File

@@ -26,6 +26,7 @@ from zerver.lib.user_groups import (
access_user_group_by_id,
access_user_group_for_setting,
access_user_groups_as_potential_subgroups,
check_user_group_name,
get_direct_memberships_of_users,
get_recursive_subgroups_for_groups,
get_subgroup_ids,
@@ -51,6 +52,7 @@ def add_user_group(
can_mention_group_id: Optional[int] = REQ(json_validator=check_int, default=None),
) -> HttpResponse:
user_profiles = user_ids_to_users(members, user_profile.realm)
name = check_user_group_name(name)
group_settings_map = {}
request_settings_dict = locals()
@@ -107,6 +109,7 @@ def edit_user_group(
user_group = access_user_group_by_id(user_group_id, user_profile)
if name is not None and name != user_group.name:
name = check_user_group_name(name)
do_update_user_group_name(user_group, name, acting_user=user_profile)
if description is not None and description != user_group.description: