paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

missedmessage_hook: Fix inaccurate docstring.

Browse Source 
If the client is no longer on the Internet,
receiver_is_off_zulip returns False, not True.
This commit is contained in:
shanukun
2021-03-03 23:31:28 +05:30
committed by Tim Abbott
parent bfefec31f4
commit eaa8862bc3
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/tornado/event_queue.py
View File

@@ -693,7 +693,7 @@ def missedmessage_hook(
"""The receiver_is_off_zulip logic used to determine whether a user """The receiver_is_off_zulip logic used to determine whether a user
has no active client suffers from a somewhat fundamental race has no active client suffers from a somewhat fundamental race
condition. If the client is no longer on the Internet, condition. If the client is no longer on the Internet,
receiver_is_off_zulip will still return true for receiver_is_off_zulip will still return False for
DEFAULT_EVENT_QUEUE_TIMEOUT_SECS, until the queue is DEFAULT_EVENT_QUEUE_TIMEOUT_SECS, until the queue is
garbage-collected. This would cause us to reliably miss garbage-collected. This would cause us to reliably miss
push/email notifying users for messages arriving during the push/email notifying users for messages arriving during the