paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 00:18:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

run-dev: Don’t rewrite the Content-Length header.

Browse Source 
A HEAD response has a Content-Length but no body; it’s not correct in
that case to let Tornado default Content-Length to 0.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-08-11 20:25:32 -07:00
committed by Tim Abbott
parent d425ab5ae5
commit ead13c11e5
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tools/run-dev.py
View File

@@ -302,12 +302,9 @@ class CombineHandler(BaseWebsocketHandler):
self._headers = httputil.HTTPHeaders() # clear tornado default header self._headers = httputil.HTTPHeaders() # clear tornado default header
for header, v in response.headers.get_all(): for header, v in response.headers.get_all():
if header != 'Content-Length':
# some header appear multiple times, eg 'Set-Cookie' # some header appear multiple times, eg 'Set-Cookie'
self.add_header(header, v) self.add_header(header, v)
if response.body: if response.body:
# rewrite Content-Length Header by the response
self.set_header('Content-Length', len(response.body))
self.write(response.body) self.write(response.body)
self.finish() self.finish()