paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 15:33:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add missing encodeURIComponent() on some API uses

Browse Source 
Fixes #2930.
This commit is contained in:
Rafid Aslam
2016-12-27 11:04:54 +07:00
committed by showell
parent f375caed46
commit ead32b179c
2 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/admin.js
View File

@@ -396,7 +396,7 @@ function _setup_page() {
$("#deactivation_user_modal").modal("hide"); $("#deactivation_user_modal").modal("hide");
meta.current_deactivate_user_modal_row.find("button").eq(0).prop("disabled", true).text("Working…"); meta.current_deactivate_user_modal_row.find("button").eq(0).prop("disabled", true).text("Working…");
channel.del({ channel.del({
url: '/json/users/' + email, url: '/json/users/' + encodeURIComponent(email),
error: function (xhr) { error: function (xhr) {
if (xhr.status.toString().charAt(0) === "4") { if (xhr.status.toString().charAt(0) === "4") {
meta.current_deactivate_user_modal_row.find("button").closest("td").html( meta.current_deactivate_user_modal_row.find("button").closest("td").html(
@@ -426,7 +426,7 @@ function _setup_page() {
var email = get_email_for_user_row(row); var email = get_email_for_user_row(row);
channel.del({ channel.del({
url: '/json/bots/' + email, url: '/json/bots/' + encodeURIComponent(email),
error: function (xhr) { error: function (xhr) {
if (xhr.status.toString().charAt(0) === "4") { if (xhr.status.toString().charAt(0) === "4") {
row.find("button").closest("td").html( row.find("button").closest("td").html(
@@ -457,7 +457,7 @@ function _setup_page() {
var email = get_email_for_user_row(row); var email = get_email_for_user_row(row);
channel.post({ channel.post({
url: '/json/users/' + email + "/reactivate", url: '/json/users/' + encodeURIComponent(email) + "/reactivate",
error: function (xhr) { error: function (xhr) {
var button = row.find("button"); var button = row.find("button");
if (xhr.status.toString().charAt(0) === "4") { if (xhr.status.toString().charAt(0) === "4") {
@@ -677,7 +677,7 @@ function _setup_page() {
var row = $(e.target).closest(".user_row"); var row = $(e.target).closest(".user_row");
var email = get_email_for_user_row(row); var email = get_email_for_user_row(row);
var url = "/json/users/" + email; var url = "/json/users/" + encodeURIComponent(email);
var data = { var data = {
is_admin: JSON.stringify(true), is_admin: JSON.stringify(true),
}; };
@@ -708,7 +708,7 @@ function _setup_page() {
var row = $(e.target).closest(".user_row"); var row = $(e.target).closest(".user_row");
var email = get_email_for_user_row(row); var email = get_email_for_user_row(row);
var url = "/json/users/" + email; var url = "/json/users/" + encodeURIComponent(email);
var data = { var data = {
is_admin: JSON.stringify(false), is_admin: JSON.stringify(false),
}; };
@@ -754,7 +754,7 @@ function _setup_page() {
e.preventDefault(); e.preventDefault();
e.stopPropagation(); e.stopPropagation();
var url = "/json/users/" + email; var url = "/json/users/" + encodeURIComponent(email);
var data = { var data = {
full_name: JSON.stringify(full_name.val()), full_name: JSON.stringify(full_name.val()),
}; };

4
static/js/subs.js
View File

@@ -317,7 +317,7 @@ function show_subscription_settings(sub_row) {
loading.make_indicator(indicator_elem); loading.make_indicator(indicator_elem);
channel.get({ channel.get({
url: "/json/streams/" + sub.name + "/members", url: "/json/streams/" + encodeURIComponent(sub.name) + "/members",
idempotent: true, idempotent: true,
success: function (data) { success: function (data) {
loading.destroy_indicator(indicator_elem); loading.destroy_indicator(indicator_elem);
@@ -1290,7 +1290,7 @@ $(function () {
var data = {stream_name: sub.name, is_private: is_private}; var data = {stream_name: sub.name, is_private: is_private};
channel.patch({ channel.patch({
url: "/json/streams/" + sub.name, url: "/json/streams/" + encodeURIComponent(sub.name),
data: data, data: data,
success: function () { success: function () {
sub = stream_data.get_sub_by_id(stream_id); sub = stream_data.get_sub_by_id(stream_id);