From ebab2a89fb0a7d594b3766276d18cba86d73181b Mon Sep 17 00:00:00 2001 From: Sahil Batra Date: Thu, 26 Aug 2021 15:04:40 +0530 Subject: [PATCH] settings: Refactor change_notification_setting to have url parameter. We refactor the change_notification_setting function to have a url parameter instead of directly using "/json/settings" directly. This change will help us in using the same code for realm-level settings also. --- static/js/settings_notifications.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/static/js/settings_notifications.js b/static/js/settings_notifications.js index 5665594ef3..e5c0cfb499 100644 --- a/static/js/settings_notifications.js +++ b/static/js/settings_notifications.js @@ -44,10 +44,10 @@ function rerender_ui() { } } -function change_notification_setting(setting, value, status_element) { +function change_notification_setting(setting, value, status_element, url) { const data = {}; data[setting] = value; - settings_ui.do_settings_change(channel.patch, "/json/settings", data, status_element); + settings_ui.do_settings_change(channel.patch, url, data, status_element); } function update_desktop_icon_count_display() { @@ -78,6 +78,7 @@ export function set_enable_marketing_emails_visibility() { export function set_up() { const container = $("#user-notification-settings"); + const patch_url = "/json/settings"; container.on("change", "input, select", function (e) { e.preventDefault(); e.stopPropagation(); @@ -91,6 +92,7 @@ export function set_up() { setting_name, settings_org.get_input_element_value(this), input_elem.closest(".subsection-parent").find(".alert-notification"), + patch_url, ); });