paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 02:48:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

actions_popover: Fix copy link not working on enter keypress.

Browse Source
This commit is contained in:
Aman Agrawal
2023-11-06 15:57:46 +00:00
committed by Tim Abbott
parent 4dfb04d501
commit ebd0dcd5d2
2 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/popover_menus.js
View File

@@ -41,6 +41,10 @@ export function popover_items_handle_keyboard(key, $items) {
let index = $items.index($items.filter(":focus")); let index = $items.index($items.filter(":focus"));
if (key === "enter" && index >= 0 && index < $items.length) { if (key === "enter" && index >= 0 && index < $items.length) {
// This is not enough for some elements which need to trigger
// natural click for them to work like ClipboardJS and follow
// the link for anchor tags. For those elements, we need to
// use `.navigate-link-on-enter` class on them.
$items.eq(index).trigger("click"); $items.eq(index).trigger("click");
return; return;
} }

2
web/templates/popovers/actions_popover.hbs
View File

@@ -110,7 +110,7 @@
{{/if}} {{/if}}
<li> <li>
<a class="copy_link" data-message-id="{{message_id}}" data-clipboard-text="{{ conversation_time_url }}" tabindex="0"> <a class="copy_link navigate-link-on-enter" data-message-id="{{message_id}}" data-clipboard-text="{{ conversation_time_url }}" tabindex="0">
<i class="fa fa-link" aria-hidden="true"></i> {{t "Copy link to message" }} <i class="fa fa-link" aria-hidden="true"></i> {{t "Copy link to message" }}
</a> </a>
</li> </li>