paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 13:33:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

right-sidebar: Enable up and down arrow keys.

Browse Source 
This users the new generic functions in stream_list.js to implement a
similar behaviour for the right sidebar (user list).

Fixes #5920.
This commit is contained in:
Florian Jüngermann
2018-02-12 23:31:17 +01:00
committed by Tim Abbott
parent b489ccc126
commit ec3e0caece
5 changed files with 203 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
frontend_tests/casper_tests/03-narrow.js
View File

@@ -437,6 +437,57 @@ casper.waitWhileVisible('#stream_filters [data-stream-name="Denmark"]', function
un_narrow();
// User search at the right sidebar
casper.then(function () {
casper.test.info('Search users using right sidebar');
casper.test.assertExists('#user_presences li [data-name="Cordelia Lear"]',
'User Cordelia Lear exists');
casper.test.assertExists('#user_presences li [data-name="King Hamlet"]',
'User King Hamlet exists');
casper.test.assertExists('#user_presences li [data-name="aaron"]',
'User aaron exists');
});
// Enter the search box and test selected suggestion navigation
// Click on search icon
casper.then(function () {
casper.evaluate(function () {
$('#user_filter_icon').expectOne()
.focus()
.trigger($.Event('click'));
});
});
casper.waitForSelector('#user_presences .highlighted_user', function () {
casper.test.info('Suggestion highlighting - initial situation');
casper.test.assertExist('#user_presences li.highlighted_user [data-name="Cordelia Lear"]',
'User Cordelia Lear is selected');
casper.test.assertDoesntExist('#user_presences li.highlighted_user [data-name="King Hamlet"]',
'User King Hamlet is not selected');
casper.test.assertDoesntExist('#user_presences li.highlighted_user [data-name="aaron"]',
'User aaron is not selected');
});
// Use arrow keys to navigate through suggestions
casper.then(function () {
// Down: Cordelia -> Hamlet
casper.sendKeys('.user-list-filter', casper.page.event.key.Down, {keepFocus: true});
// Up: Hamlet -> Cordelia
casper.sendKeys('.user-list-filter', casper.page.event.key.Up, {keepFocus: true});
// Up: Cordelia -> aaron
casper.sendKeys('.user-list-filter', casper.page.event.key.Up, {keepFocus: true});
});
casper.waitForSelector('#user_presences li.highlighted_user [data-name="aaron"]', function () {
casper.test.info('Suggestion highlighting - after arrow key navigation');
casper.test.assertDoesntExist('#user_presences li.highlighted_user [data-name="Cordelia Lear"]',
'User Cordelia Lear not is selected');
casper.test.assertDoesntExist('#user_presences li.highlighted_user [data-name="King Hamlet"]',
'User King Hamlet is not selected');
casper.test.assertExist('#user_presences li.highlighted_user [data-name="aaron"]',
'User aaron is selected');
});
common.then_log_out();
// Run the above queued actions.