js: Convert static/js/unread_ui.js to ES6 module.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

.eslintrc.json

@@ -256,7 +256,6 @@
                 "ui_util": false,
                 "unread": false,
                 "unread_ops": false,
-                "unread_ui": false,
                 "upload": false,
                 "upload_widget": false,
                 "user_events": false,

frontend_tests/node_tests/message_events.js

@@ -2,6 +2,8 @@
 
 const {strict: assert} = require("assert");
 
+const rewiremock = require("rewiremock/node");
+
 const {set_global, zrequire} = require("../zjsunit/namespace");
 const {run_test} = require("../zjsunit/test");
 
@@ -13,7 +15,10 @@ const notifications = set_global("notifications", {});
 const page_params = set_global("page_params", {});
 const pm_list = set_global("pm_list", {});
 const stream_list = set_global("stream_list", {});
-const unread_ui = set_global("unread_ui", {});
+const unread_ui = {__esModule: true};
+
+rewiremock("../../static/js/unread_ui").with(unread_ui);
+rewiremock.enable();
 
 const message_events = zrequire("message_events");
 const message_store = zrequire("message_store");
@@ -151,3 +156,4 @@ run_test("update_messages", () => {
         },
     ]);
 });
+rewiremock.disable();

frontend_tests/node_tests/pm_list.js

@@ -16,7 +16,8 @@ set_global("stream_popover", {
     hide_topic_popover() {},
 });
 const unread = set_global("unread", {});
-const unread_ui = set_global("unread_ui", {});
+const unread_ui = {__esModule: true};
+rewiremock("../../static/js/unread_ui").with(unread_ui);
 const vdom = {
     __esModule: true,
     render: () => "fake-dom-for-pm-list",

frontend_tests/node_tests/stream_list.js

@@ -28,7 +28,6 @@ rewiremock("../../static/js/keydown_util").with({
 
 rewiremock.enable();
 
-zrequire("unread_ui");
 const Filter = zrequire("Filter", "js/filter");
 const stream_sort = zrequire("stream_sort");
 const stream_color = zrequire("stream_color");

frontend_tests/node_tests/top_left_corner.js

@@ -10,7 +10,6 @@ set_global("resize", {
     resize_stream_filters_container: () => {},
 });
 const Filter = zrequire("Filter", "js/filter");
-zrequire("unread_ui");
 const people = zrequire("people");
 
 const top_left_corner = zrequire("top_left_corner");

frontend_tests/node_tests/tutorial.js

@@ -33,7 +33,8 @@ const overlays = set_global("overlays", {});
 const resize = set_global("resize", {});
 let stream_list = set_global("stream_list", {});
 let unread_ops = set_global("unread_ops", {});
-const unread_ui = set_global("unread_ui", {});
+const unread_ui = {__esModule: true};
+rewiremock("../../static/js/unread_ui").with(unread_ui);
 const channel = {__esModule: true};
 rewiremock("../../static/js/channel").with(channel);
 const message_viewport = set_global("message_viewport", {});

frontend_tests/node_tests/ui_init.js

@@ -88,7 +88,7 @@ set_global("settings_toggle", {initialize() {}});
 set_global("subs", {initialize() {}});
 set_global("timerender", {initialize() {}});
 const ui = set_global("ui", {initialize() {}});
-set_global("unread_ui", {initialize() {}});
+rewiremock("../../static/js/unread_ui").with({initialize() {}});
 
 server_events.home_view_loaded = () => true;
 

static/js/bundles/app.js

@@ -17,7 +17,6 @@ import "../i18n";
 import "../fold_dict";
 import "../input_pill";
 import "../setup";
-import "../unread_ui";
 import "../unread_ops";
 import "../muting";
 import "../muting_ui";

static/js/global.d.ts

@@ -127,7 +127,6 @@ declare let ui_report: any;
 declare let ui_util: any;
 declare let unread: any;
 declare let unread_ops: any;
-declare let unread_ui: any;
 declare let upload: any;
 declare let upload_widget: any;
 declare let user_events: any;

static/js/message_events.js

@@ -4,6 +4,7 @@ const alert_words = require("./alert_words");
 const channel = require("./channel");
 const huddle_data = require("./huddle_data");
 const message_edit_history = require("./message_edit_history");
+const unread_ui = require("./unread_ui");
 const util = require("./util");
 
 function maybe_add_narrowed_messages(messages, msg_list) {

static/js/message_util.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const loading = require("./loading");
+const unread_ui = require("./unread_ui");
 
 exports.do_unread_count_updates = function do_unread_count_updates(messages) {
     unread.process_loaded_messages(messages);

static/js/muting_ui.js

@@ -6,6 +6,7 @@ const render_topic_muted = require("../templates/topic_muted.hbs");
 const channel = require("./channel");
 const feedback_widget = require("./feedback_widget");
 const settings_muting = require("./settings_muting");
+const unread_ui = require("./unread_ui");
 
 function timestamp_ms() {
     return Date.now();

static/js/panels.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const {localstorage} = require("./localstorage");
+const unread_ui = require("./unread_ui");
 const util = require("./util");
 
 const resize_app = function () {

static/js/pm_list.js

@@ -2,6 +2,7 @@
 
 const people = require("./people");
 const pm_conversations = require("./pm_conversations");
+const unread_ui = require("./unread_ui");
 const vdom = require("./vdom");
 
 let prior_dom;

static/js/settings_notifications.js

@@ -5,6 +5,7 @@ const render_stream_specific_notification_row = require("../templates/settings/s
 const channel = require("./channel");
 const settings_config = require("./settings_config");
 const settings_ui = require("./settings_ui");
+const unread_ui = require("./unread_ui");
 
 exports.get_notifications_table_row_data = function (notify_settings) {
     return settings_config.general_notifications_table_labels.realm.map((column, index) => {

static/js/top_left_corner.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const people = require("./people");
+const unread_ui = require("./unread_ui");
 
 exports.update_count_in_dom = function (unread_count_elem, count) {
     const count_span = unread_count_elem.find(".count");

static/js/ui_init.js

@@ -22,6 +22,7 @@ const spoilers = require("./spoilers");
 const topic_zoom = require("./topic_zoom");
 const tutorial = require("./tutorial");
 const typing = require("./typing");
+const unread_ui = require("./unread_ui");
 const user_status = require("./user_status");
 const user_status_ui = require("./user_status_ui");
 

static/js/unread_ops.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const channel = require("./channel");
+const unread_ui = require("./unread_ui");
 
 exports.mark_all_as_read = function () {
     unread.declare_bankruptcy();

static/js/unread_ui.js

@@ -1,5 +1,3 @@
-"use strict";
-
 let last_mention_count = 0;
 
 function do_new_messages_animation(li) {
@@ -15,14 +13,14 @@ function do_new_messages_animation(li) {
     setTimeout(end_animation, 6000);
 }
 
-exports.animate_mention_changes = function (li, new_mention_count) {
+export function animate_mention_changes(li, new_mention_count) {
     if (new_mention_count > last_mention_count) {
         do_new_messages_animation(li);
     }
     last_mention_count = new_mention_count;
-};
+}
 
-exports.set_count_toggle_button = function (elem, count) {
+export function set_count_toggle_button(elem, count) {
     if (count === 0) {
         if (elem.is(":animated")) {
             return elem.stop(true, true).hide();
@@ -34,9 +32,9 @@ exports.set_count_toggle_button = function (elem, count) {
     }
     elem.show(500);
     return elem.text("1k+");
-};
+}
 
-exports.update_unread_counts = function () {
+export function update_unread_counts() {
     // Pure computation:
     const res = unread.get_counts();
 
@@ -51,10 +49,10 @@ exports.update_unread_counts = function () {
     const notifiable_unread_count = unread.calculate_notifiable_count(res);
     notifications.update_unread_counts(notifiable_unread_count, res.private_message_count);
 
-    exports.set_count_toggle_button($("#streamlist-toggle-unreadcount"), res.home_unread_messages);
-};
+    set_count_toggle_button($("#streamlist-toggle-unreadcount"), res.home_unread_messages);
+}
 
-exports.should_display_bankruptcy_banner = function () {
+export function should_display_bankruptcy_banner() {
     // Until we've handled possibly declaring bankruptcy, don't show
     // unread counts since they only consider messages that are loaded
     // client side and may be different from the numbers reported by
@@ -75,10 +73,8 @@ exports.should_display_bankruptcy_banner = function () {
     }
 
     return false;
-};
+}
 
-exports.initialize = function () {
-    exports.update_unread_counts();
-};
-
-window.unread_ui = exports;
+export function initialize() {
+    update_unread_counts();
+}