paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 00:18:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix several type annotations for mypy 0.4.6 compatibility.

Browse Source 
A few functions had arguments removed without having their type
annotations updated accordingly. As a result mypy version 0.4.6
thinks that the first type in the annotation is supposed to be
the type of `self`, a new mypy feature which we are not intending
to use here.
This commit is contained in:
Reid Barton
2016-12-03 13:50:14 -05:00
committed by Tim Abbott
parent abc2ff4a06
commit ecfa397567
3 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/lib/test_helpers.py
View File

@@ -189,7 +189,7 @@ def get_user_messages(user_profile):
class DummyHandler(object): class DummyHandler(object):
def __init__(self): def __init__(self):
# type: (Callable) -> None # type: () -> None
allocate_handler_id(self) # type: ignore # this is a testing mock allocate_handler_id(self) # type: ignore # this is a testing mock
class POSTRequestMock(object): class POSTRequestMock(object):

2
zerver/tests/test_external.py
View File

@@ -69,7 +69,7 @@ class RateLimitTests(ZulipTestCase):
remove_ratelimit_rule(1, 5) remove_ratelimit_rule(1, 5)
def send_api_message(self, email, content): def send_api_message(self, email, content):
# type: (text_type, text_type, text_type) -> HttpResponse # type: (text_type, text_type) -> HttpResponse
return self.client_post("/api/v1/messages", {"type": "stream", return self.client_post("/api/v1/messages", {"type": "stream",
"to": "Verona", "to": "Verona",
"client": "test suite", "client": "test suite",

4
zerver/tornado/event_queue.py
View File

@@ -141,7 +141,7 @@ class ClientDescriptor(object):
self.finish_current_handler() self.finish_current_handler()
def finish_current_handler(self): def finish_current_handler(self):
# type: (bool) -> bool # type: () -> bool
if self.current_handler_id is not None: if self.current_handler_id is not None:
err_msg = "Got error finishing handler for queue %s" % (self.event_queue.id,) err_msg = "Got error finishing handler for queue %s" % (self.event_queue.id,)
try: try:
@@ -193,7 +193,7 @@ class ClientDescriptor(object):
self._timeout_handle = ioloop.add_timeout(heartbeat_time, timeout_callback) self._timeout_handle = ioloop.add_timeout(heartbeat_time, timeout_callback)
def disconnect_handler(self, client_closed=False): def disconnect_handler(self, client_closed=False):
# type: (bool, bool) -> None # type: (bool) -> None
if self.current_handler_id: if self.current_handler_id:
clear_descriptor_by_handler_id(self.current_handler_id, None) clear_descriptor_by_handler_id(self.current_handler_id, None)
clear_handler_by_id(self.current_handler_id) clear_handler_by_id(self.current_handler_id)