paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

lint: Add regex to disallow i18n string concatenation.

Browse Source 
Fixes #6398
This commit is contained in:
Umair Khan
2017-09-05 11:37:25 +05:00
committed by showell
parent d52760d2ef
commit ee6235d716
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
tools/linter_lib/custom_check.py
View File

@@ -135,6 +135,12 @@ def build_custom_checkers(by_lang):
'description': 'The module blueslip has no function warning, try using blueslip.warn'},
{'pattern': '[)]{$',
'description': 'Missing space between ) and {'},
{'pattern': 'i18n\.t\([^)]+[^,\{]$',
'description': 'i18n string should not be a multiline string'},
{'pattern': 'i18n\.t([^)]+?\+.+?)',
'description': 'Do not concatenate i18n strings'},
{'pattern': 'i18n\.t([^+]+?).+?\+',
'description': 'Do not concatenate i18n strings'},
{'pattern': '["\']json/',
'description': 'Relative URL for JSON route not supported by i18n'},
# This rule is constructed with + to avoid triggering on itself