paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

webhooks/github: Improve punctuation.

Browse Source
This commit is contained in:
Eeshan Garg
2019-05-08 22:21:28 -02:30
committed by Tim Abbott
parent 9516699c73
commit ef070ef019
3 changed files with 32 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
zerver/webhooks/github/view.py
View File

@@ -77,7 +77,7 @@ def get_membership_body(payload: Dict[str, Any]) -> str:
member = payload['member']
team_name = payload['team']['name']
return u"{sender} {action} [{username}]({html_url}) {preposition} the {team_name} team".format(
return u"{sender} {action} [{username}]({html_url}) {preposition} the {team_name} team.".format(
sender=get_sender_name(payload),
action=action,
username=member['login'],
@@ -87,7 +87,7 @@ def get_membership_body(payload: Dict[str, Any]) -> str:
)
def get_member_body(payload: Dict[str, Any]) -> str:
return u"{} {} [{}]({}) to [{}]({})".format(
return u"{} {} [{}]({}) to [{}]({}).".format(
get_sender_name(payload),
payload['action'],
payload['member']['login'],
@@ -134,25 +134,25 @@ def get_issue_comment_body(payload: Dict[str, Any],
def get_fork_body(payload: Dict[str, Any]) -> str:
forkee = payload['forkee']
return u"{} forked [{}]({})".format(
return u"{} forked [{}]({}).".format(
get_sender_name(payload),
forkee['name'],
forkee['html_url']
)
def get_deployment_body(payload: Dict[str, Any]) -> str:
return u'{} created new deployment'.format(
return u'{} created new deployment.'.format(
get_sender_name(payload),
)
def get_change_deployment_status_body(payload: Dict[str, Any]) -> str:
return u'Deployment changed status to {}'.format(
return u'Deployment changed status to {}.'.format(
payload['deployment_status']['state'],
)
def get_create_or_delete_body(payload: Dict[str, Any], action: str) -> str:
ref_type = payload['ref_type']
return u'{} {} {} {}'.format(
return u'{} {} {} {}.'.format(
get_sender_name(payload),
action,
ref_type,
@@ -196,7 +196,7 @@ def get_push_commits_body(payload: Dict[str, Any]) -> str:
)
def get_public_body(payload: Dict[str, Any]) -> str:
return u"{} made [the repository]({}) public".format(
return u"{} made [the repository]({}) public.".format(
get_sender_name(payload),
payload['repository']['html_url'],
)
@@ -213,26 +213,26 @@ def get_wiki_pages_body(payload: Dict[str, Any]) -> str:
return u"{}:\n{}".format(get_sender_name(payload), wiki_info.rstrip())
def get_watch_body(payload: Dict[str, Any]) -> str:
return u"{} starred [the repository]({})".format(
return u"{} starred [the repository]({}).".format(
get_sender_name(payload),
payload['repository']['html_url']
)
def get_repository_body(payload: Dict[str, Any]) -> str:
return u"{} {} [the repository]({})".format(
return u"{} {} [the repository]({}).".format(
get_sender_name(payload),
payload.get('action'),
payload['repository']['html_url']
)
def get_add_team_body(payload: Dict[str, Any]) -> str:
return u"[The repository]({}) was added to team {}".format(
return u"[The repository]({}) was added to team {}.".format(
payload['repository']['html_url'],
payload['team']['name']
)
def get_release_body(payload: Dict[str, Any]) -> str:
return u"{} published [the release]({})".format(
return u"{} published [the release]({}).".format(
get_sender_name(payload),
payload['release']['html_url'],
)
@@ -252,7 +252,7 @@ def get_page_build_body(payload: Dict[str, Any]) -> str:
CONTENT_MESSAGE_TEMPLATE.format(message=build['error']['message'])
)
return u"Github Pages build, trigerred by {}, {}".format(
return u"Github Pages build, trigerred by {}, {}.".format(
payload['build']['pusher']['login'],
action
)
@@ -265,7 +265,7 @@ def get_status_body(payload: Dict[str, Any]) -> str:
)
else:
status = payload['state']
return u"[{}]({}) changed its status to {}".format(
return u"[{}]({}) changed its status to {}.".format(
payload['sha'][:7], # TODO
payload['commit']['html_url'],
status