paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Fix real-time sync for account settings.

Browse Source 
This restores the property that changing one's name in on browser's
"account settings" also changes the user's name in other browser windows'
"account settings" pages.
This commit is contained in:
Tim Abbott
2018-02-01 16:24:26 -08:00
parent 77fefcf8b7
commit ef42bb2e73
3 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
frontend_tests/node_tests/user_events.js
View File

@@ -30,6 +30,7 @@ set_global('compose', {
set_global('settings_account', { set_global('settings_account', {
update_email: function () {}, update_email: function () {},
update_full_name: function () {},
}); });
set_global('message_live_update', { set_global('message_live_update', {

17
static/js/settings_account.js
View File

@@ -10,6 +10,21 @@ exports.update_email = function (new_email) {
} }
}; };
exports.update_full_name = function (new_full_name) {
var full_name_field = $("#change_full_name button #full_name_value");
if (full_name_field) {
full_name_field.text(new_full_name);
}
// Arguably, this should work more like how the `update_email`
// flow works, where we update the name in the modal on open,
// rather than updating it here, but this works.
var full_name_input = $(".full_name_change_container input[name='full_name']");
if (full_name_input) {
full_name_input.val(new_full_name);
}
};
function settings_change_error(message, xhr) { function settings_change_error(message, xhr) {
ui_report.error(message, xhr, $('#account-settings-status').expectOne()); ui_report.error(message, xhr, $('#account-settings-status').expectOne());
} }
@@ -177,7 +192,6 @@ exports.set_up = function () {
e.stopPropagation(); e.stopPropagation();
var change_full_name_info = $('#change_full_name_modal').find(".change_full_name_info").expectOne(); var change_full_name_info = $('#change_full_name_modal').find(".change_full_name_info").expectOne();
var data = {}; var data = {};
var full_name_field = $("#change_full_name button #full_name_value").expectOne();
data.full_name = $('.full_name_change_container').find("input[name='full_name']").val(); data.full_name = $('.full_name_change_container').find("input[name='full_name']").val();
channel.patch({ channel.patch({
@@ -186,7 +200,6 @@ exports.set_up = function () {
success: function (data) { success: function (data) {
if ('full_name' in data) { if ('full_name' in data) {
settings_change_success(i18n.t("Updated settings!")); settings_change_success(i18n.t("Updated settings!"));
full_name_field.html(data.full_name);
} else { } else {
settings_change_success(i18n.t("No changes made.")); settings_change_success(i18n.t("No changes made."));
} }

3
static/js/user_events.js
View File

@@ -36,6 +36,9 @@ exports.update_person = function update(person) {
activity.redraw(); activity.redraw();
message_live_update.update_user_full_name(person.user_id, person.full_name); message_live_update.update_user_full_name(person.user_id, person.full_name);
pm_list.update_private_messages(); pm_list.update_private_messages();
if (people.is_my_user_id(person.user_id)) {
settings_account.update_full_name(person.full_name);
}
} }
if (_.has(person, 'is_admin')) { if (_.has(person, 'is_admin')) {