paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

int_dict: Fix type errors for user_groups.

Browse Source 
This fixes some harmless type errors from the
following commit:

    6ec5a1f306

The IntDict code automatically converts strings to
integers, so this was not a user-facing problem, but
we want to have our callers do the conversions
explicitly.
This commit is contained in:
Steve Howell
2020-01-27 17:48:46 +00:00
committed by showell
parent b80f8babcc
commit ef892271dc
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/message_list_view.js
View File

@@ -48,7 +48,7 @@ function get_user_group_id_for_mention_button(elem) {
const user_group_id = $(elem).attr('data-user-group-id');
if (user_group_id) {
return user_group_id;
return parseInt(user_group_id, 10);
}
return;

2
static/js/settings_user_groups.js
View File

@@ -298,7 +298,7 @@ exports.set_up = function () {
});
$('#user-groups').on('click', '.delete', function () {
const group_id = $(this).parents('.user-group').attr('id');
const group_id = parseInt($(this).parents('.user-group').attr('id'), 10);
if (!exports.can_edit(group_id)) {
return;
}