paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

design: Use CSS instead of disabled property for non-editable text.

Browse Source 
The disabled property actually prevented text selection, so it seems
better to use CSS through the `readonly="readonly"` property.
For this, swapped .prop() with .attr() since .prop() was setting it as
`readonly=""`.
This commit is contained in:
vaibhavrajsingh2001
2020-04-16 19:00:31 +05:30
committed by Tim Abbott
parent 3e78b3cdc3
commit f0c5b1a8d7
2 changed files with 5 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
static/js/message_edit.js
View File

@@ -264,23 +264,19 @@ function edit_message(row, raw_content) {
const copy_message = row.find('.copy_message');
if (editability === editability_types.NO) {
message_edit_content.prop("readonly", "readonly");
message_edit_topic.prop("readonly", "readonly");
message_edit_content.attr("disabled", "disabled");
message_edit_topic.attr("disabled", "disabled");
message_edit_content.attr("readonly", "readonly");
message_edit_topic.attr("readonly", "readonly");
new ClipboardJS(copy_message[0]);
} else if (editability === editability_types.NO_LONGER) {
// You can currently only reach this state in non-streams. If that
// changes (e.g. if we stop allowing topics to be modified forever
// in streams), then we'll need to disable
// row.find('input.message_edit_topic') as well.
message_edit_content.prop("readonly", "readonly");
message_edit_content.attr("disabled", "disabled");
message_edit_content.attr("readonly", "readonly");
message_edit_countdown_timer.text(i18n.t("View source"));
new ClipboardJS(copy_message[0]);
} else if (editability === editability_types.TOPIC_ONLY) {
message_edit_content.prop("readonly", "readonly");
message_edit_content.attr("disabled", "disabled");
message_edit_content.attr("readonly", "readonly");
// Hint why you can edit the topic but not the message content
message_edit_countdown_timer.text(i18n.t("Topic editing only"));
new ClipboardJS(copy_message[0]);

1
static/styles/night_mode.scss
View File

@@ -90,6 +90,7 @@ on a dark background, and don't change the dark labels dark either. */
/* these are converting grey things to "new grey" */
*[disabled=disabled],
*[readonly=readonly],
.sidebar-title,
.recipient_row_date {
color: inherit;