paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-14 10:57:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

models: Remove unused ModelReprMixin class.

Browse Source 
It appeared to be used as a base class in various Django migrations,
but because it didn't define any model fields, it wasn't actually.
This commit is contained in:
Tim Abbott
2018-05-15 19:11:22 -07:00
parent 351fab204b
commit f0ef335412
6 changed files with 12 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
zerver/lib/str_utils.py
View File

@@ -53,22 +53,3 @@ def force_str(s: Union[str, bytes], encoding: str='utf-8') -> str:
return s.decode(encoding)
else:
raise TypeError("force_str expects a string type")
class ModelReprMixin:
"""
This mixin provides a python 2 and 3 compatible way of handling string representation of a model.
When declaring a model, inherit this mixin before django.db.models.Model.
Define __unicode__ on your model which returns a str object.
This mixin will automatically define __str__ and __repr__.
"""
def __unicode__(self) -> str:
# Originally raised an exception, but Django (e.g. the ./manage.py shell)
# was catching the exception and not displaying any sort of error
return "Implement __unicode__ in your subclass of ModelReprMixin!"
def __str__(self) -> str:
return force_str(self.__unicode__())
def __repr__(self) -> str:
return force_str(self.__unicode__())