lint: Fix remaining no-unused-vars eslint rule violations.

This commit is contained in:
Tim Abbott
2016-12-14 22:26:09 -08:00
parent fe2d38392f
commit f0f4be4af7
8 changed files with 13 additions and 11 deletions

View File

@@ -178,7 +178,9 @@
"no-underscore-dangle": 1, "no-underscore-dangle": 1,
"no-loop-func": 2, "no-loop-func": 2,
"no-labels": 2, "no-labels": 2,
"no-unused-vars": 1, "no-unused-vars": ["error", { "vars": "local", "args": "after-used",
"varsIgnorePattern": "print_elapsed_time"
}],
"no-script-url": 2, "no-script-url": 2,
"no-proto": 2, "no-proto": 2,
"no-iterator": 2, "no-iterator": 2,

View File

@@ -128,13 +128,13 @@ $(function () {
e.stopPropagation(); e.stopPropagation();
popovers.hide_all(); popovers.hide_all();
}); });
$("body").on("click", "a", function (e) { $("body").on("click", "a", function () {
if (document.activeElement === this) { if (document.activeElement === this) {
ui.blur_active_element(); ui.blur_active_element();
} }
}); });
$(window).on("focus", function (e) { $(window).on("focus", function () {
meta.focusing = true; meta.focusing = true;
}); });

View File

@@ -1065,7 +1065,7 @@ $(function () {
Dropbox.choose(options); Dropbox.choose(options);
}); });
function uploadStarted(i, file, len) { function uploadStarted() {
$("#compose-send-button").attr("disabled", ""); $("#compose-send-button").attr("disabled", "");
$("#send-status").addClass("alert-info") $("#send-status").addClass("alert-info")
.show(); .show();
@@ -1107,7 +1107,7 @@ $(function () {
$("#error-msg").text(msg); $("#error-msg").text(msg);
} }
function uploadFinished(i, file, response, time) { function uploadFinished(i, file, response) {
if (response.uri === undefined) { if (response.uri === undefined) {
return; return;
} }

View File

@@ -36,7 +36,7 @@ exports.notify_with_undo_option = (function () {
} }
} }
}; };
var interval = setInterval(function () { setInterval(function () {
if (meta.hide_me_time < new Date().getTime() && !meta.alert_hover_state) { if (meta.hide_me_time < new Date().getTime() && !meta.alert_hover_state) {
animate.fadeOut(); animate.fadeOut();
} }

View File

@@ -319,7 +319,7 @@ exports.activate = function (raw_operators, opts) {
num_after: 50, num_after: 50,
msg_list: message_list.narrowed, msg_list: message_list.narrowed,
use_first_unread_anchor: opts.first_unread_from_server, use_first_unread_anchor: opts.first_unread_from_server,
cont: function (messages) { cont: function () {
ui.hide_loading_more_messages_indicator(); ui.hide_loading_more_messages_indicator();
if (defer_selecting_closest) { if (defer_selecting_closest) {
maybe_select_closest(); maybe_select_closest();

View File

@@ -730,7 +730,7 @@ function _setup_page() {
}); });
$("#bots_list").on("click", "a.download_bot_zuliprc", function (e) { $("#bots_list").on("click", "a.download_bot_zuliprc", function () {
var bot_info = $(this).parent().parent(); var bot_info = $(this).parent().parent();
var email = bot_info.find(".email .value").text(); var email = bot_info.find(".email .value").text();
var api_key = bot_info.find(".api_key .api-key-value-and-button .value").text(); var api_key = bot_info.find(".api_key .api-key-value-and-button .value").text();
@@ -740,7 +740,7 @@ function _setup_page() {
)); ));
}); });
$("#download_zuliprc").on("click", function (e) { $("#download_zuliprc").on("click", function () {
$(this).attr("href", settings.generate_zuliprc_uri( $(this).attr("href", settings.generate_zuliprc_uri(
page_params.email, page_params.email,
$("#api_key_value").text() $("#api_key_value").text()

View File

@@ -428,7 +428,7 @@ $(function () {
} }
}); });
$(document).on('narrow_deactivated.zulip', function (event) { $(document).on('narrow_deactivated.zulip', function () {
reset_to_unnarrowed(); reset_to_unnarrowed();
$("#global_filters li[data-name='home']").addClass('active-filter'); $("#global_filters li[data-name='home']").addClass('active-filter');
}); });

View File

@@ -545,7 +545,7 @@ exports.setup_page = function (callback) {
{ label: "Subscribed" }, { label: "Subscribed" },
{ label: "All Streams" }, { label: "All Streams" },
], ],
callback: function (name) { callback: function () {
actually_filter_streams(); actually_filter_streams();
remove_temporarily_miscategorized_streams(); remove_temporarily_miscategorized_streams();
} }