paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 06:53:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

lib/integrations: Stop passing kwargs as positional args to super.

Browse Source
This commit is contained in:
Eeshan Garg
2017-06-13 11:38:07 -02:30
committed by Tim Abbott
parent b741f45408
commit f1c209b38d
1 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
zerver/lib/integrations.py
View File

@@ -91,7 +91,14 @@ class WebhookIntegration(Integration):
# type: (str, Optional[str], Optional[str], Optional[str], Optional[str], Optional[str], Optional[str], Optional[str], Optional[str]) -> None # type: (str, Optional[str], Optional[str], Optional[str], Optional[str], Optional[str], Optional[str], Optional[str], Optional[str]) -> None
if client_name is None: if client_name is None:
client_name = self.DEFAULT_CLIENT_NAME.format(name=name.title()) client_name = self.DEFAULT_CLIENT_NAME.format(name=name.title())
super(WebhookIntegration, self).__init__(name, client_name, logo, secondary_line_text, display_name, stream_name=stream_name) super(WebhookIntegration, self).__init__(
name,
client_name,
logo=logo,
secondary_line_text=secondary_line_text,
display_name=display_name,
stream_name=stream_name
)
if function is None: if function is None:
function = self.DEFAULT_FUNCTION_PATH.format(name=name) function = self.DEFAULT_FUNCTION_PATH.format(name=name)
@@ -132,7 +139,10 @@ class HubotLozenge(Integration):
if git_url is None: if git_url is None:
git_url = self.GIT_URL_TEMPLATE.format(name) git_url = self.GIT_URL_TEMPLATE.format(name)
self.git_url = git_url self.git_url = git_url
super(HubotLozenge, self).__init__(name, name, logo, display_name=display_name) super(HubotLozenge, self).__init__(
name, name,
logo=logo, display_name=display_name
)
class GithubIntegration(WebhookIntegration): class GithubIntegration(WebhookIntegration):
""" """
@@ -145,8 +155,16 @@ class GithubIntegration(WebhookIntegration):
url = self.DEFAULT_URL.format(name='github') url = self.DEFAULT_URL.format(name='github')
super(GithubIntegration, self).__init__( super(GithubIntegration, self).__init__(
name, client_name, logo, secondary_line_text, name,
function, url, display_name, doc, stream_name) client_name=client_name,
logo=logo,
secondary_line_text=secondary_line_text,
function=function,
url=url,
display_name=display_name,
doc=doc,
stream_name=stream_name
)
@property @property
def url_object(self): def url_object(self):