From f33ef8f206afe81dfef886550de9ad3b96dd0dfe Mon Sep 17 00:00:00 2001 From: Niloth P <20315308+Niloth-p@users.noreply.github.com> Date: Sun, 12 Oct 2025 06:03:57 +0530 Subject: [PATCH] integrations: Rename IFTTT view function to match conventions. --- zerver/lib/integrations.py | 7 +------ zerver/webhooks/ifttt/tests.py | 2 +- zerver/webhooks/ifttt/view.py | 2 +- 3 files changed, 3 insertions(+), 8 deletions(-) diff --git a/zerver/lib/integrations.py b/zerver/lib/integrations.py index 0ea3841c40..0f752a9350 100644 --- a/zerver/lib/integrations.py +++ b/zerver/lib/integrations.py @@ -536,12 +536,7 @@ WEBHOOK_INTEGRATIONS: list[WebhookIntegration] = [ WebhookIntegration("helloworld", ["misc"], display_name="Hello World"), WebhookIntegration("heroku", ["deployment"]), WebhookIntegration("homeassistant", ["misc"], display_name="Home Assistant"), - WebhookIntegration( - "ifttt", - ["meta-integration"], - function="zerver.webhooks.ifttt.view.api_iftt_app_webhook", - display_name="IFTTT", - ), + WebhookIntegration("ifttt", ["meta-integration"], display_name="IFTTT"), WebhookIntegration("insping", ["monitoring"]), WebhookIntegration("intercom", ["customer-support"]), # Avoid collision with jira-plugin's doc "jira/doc.md". diff --git a/zerver/webhooks/ifttt/tests.py b/zerver/webhooks/ifttt/tests.py index 0fde007739..8634155e9d 100644 --- a/zerver/webhooks/ifttt/tests.py +++ b/zerver/webhooks/ifttt/tests.py @@ -5,7 +5,7 @@ class IFTTTHookTests(WebhookTestCase): CHANNEL_NAME = "ifttt" URL_TEMPLATE = "/api/v1/external/ifttt?stream={stream}&api_key={api_key}" WEBHOOK_DIR_NAME = "ifttt" - VIEW_FUNCTION_NAME = "api_iftt_app_webhook" + VIEW_FUNCTION_NAME = "api_ifttt_webhook" def test_ifttt_when_subject_and_body_are_correct(self) -> None: expected_topic_name = "Email sent from email@email.com" diff --git a/zerver/webhooks/ifttt/view.py b/zerver/webhooks/ifttt/view.py index 8e712baadc..05315ca853 100644 --- a/zerver/webhooks/ifttt/view.py +++ b/zerver/webhooks/ifttt/view.py @@ -13,7 +13,7 @@ from zerver.models import UserProfile @webhook_view("IFTTT") @typed_endpoint -def api_iftt_app_webhook( +def api_ifttt_webhook( request: HttpRequest, user_profile: UserProfile, *,