paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 13:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose_validate: Avoid jQuery sizzle extension :visible.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2025-05-09 14:08:28 -07:00
committed by Tim Abbott
parent 7c6d040fd8
commit f3cb557fb2
2 changed files with 2 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/compose_validate.ts
View File

@@ -1132,7 +1132,7 @@ export let validate = (scheduling_message: boolean, show_banner = true): boolean
$("textarea#compose-textarea").toggleClass("invalid", false);
}
if ($("#zephyr-mirror-error").is(":visible")) {
if ($("#zephyr-mirror-error").hasClass("show")) {
const error_message = $t({
defaultMessage: "You need to be running Zephyr mirroring in order to send messages!",
});

10
web/tests/compose_validate.test.cjs
View File

@@ -174,8 +174,6 @@ function initialize_pm_pill(mock_template) {
on_pill_create_or_remove: compose_recipient.update_compose_area_placeholder_text,
});
$("#zephyr-mirror-error").is = noop;
mock_template("input_pill.hbs", false, () => "<div>pill-html</div>");
mock_banners();
@@ -317,15 +315,9 @@ test_ui("validate", ({mock_template, override}) => {
// Now add content to compose, and expect to see the banner.
add_content_to_compose_box();
expected_invalid_state = false;
let zephyr_checked = false;
$("#zephyr-mirror-error").is = (arg) => {
assert.equal(arg, ":visible");
zephyr_checked = true;
return true;
};
$("#zephyr-mirror-error").addClass("show");
$("#send_message_form").set_find_results(".message-textarea", $("textarea#compose-textarea"));
assert.ok(!compose_validate.validate());
assert.ok(zephyr_checked);
assert.ok(zephyr_error_rendered);
initialize_pm_pill(mock_template);