paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 00:23:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

support: Clarify what missing data caused MissingDataError.

Browse Source 
Update strings for support views to indicate if analytics data or
audit log data was missing and caused a MissingDataError.
This commit is contained in:
Lauryn Menard
2024-01-05 22:18:41 +01:00
committed by Tim Abbott
parent 63363ba50a
commit f3d0ec15ca
3 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
analytics/tests/test_support_views.py
View File

@@ -285,7 +285,7 @@ class TestRemoteServerSupportEndpoint(ZulipTestCase):
"/activity/remote/support", {"q": f"zulip-{server}.example.com"} "/activity/remote/support", {"q": f"zulip-{server}.example.com"}
) )
self.assert_in_success_response( self.assert_in_success_response(
["<b>Max monthly messages</b>: Recent data missing"], result ["<b>Max monthly messages</b>: Recent analytics data missing"], result
) )
assert_server_details_in_response(result, f"zulip-{server}.example.com") assert_server_details_in_response(result, f"zulip-{server}.example.com")
assert_realm_details_in_response(result, f"realm-name-{server}", f"realm-host-{server}") assert_realm_details_in_response(result, f"realm-name-{server}", f"realm-host-{server}")

4
analytics/views/support.py
View File

@@ -528,7 +528,9 @@ def remote_servers_support(
remote_server remote_server
) )
except MissingDataError: except MissingDataError:
remote_server_to_max_monthly_messages[remote_server.id] = "Recent data missing" remote_server_to_max_monthly_messages[
remote_server.id
] = "Recent analytics data missing"
context["remote_servers"] = remote_servers context["remote_servers"] = remote_servers
context["remote_servers_support_data"] = server_support_data context["remote_servers_support_data"] = server_support_data

4
corporate/lib/support.py
View File

@@ -150,7 +150,9 @@ def get_current_plan_data_for_support_view(billing_session: BillingSession) -> P
try: try:
plan_data.licenses_used = billing_session.current_count_for_billed_licenses() plan_data.licenses_used = billing_session.current_count_for_billed_licenses()
except MissingDataError: # nocoverage except MissingDataError: # nocoverage
plan_data.warning = "Recent data missing: No information for used licenses" plan_data.warning = (
"Recent audit log data missing: No information for used licenses"
)
assert plan_data.current_plan is not None # for mypy assert plan_data.current_plan is not None # for mypy