paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-09 08:26:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

misc: Replace "day mode" with "light theme" in comments.

Browse Source
This commit is contained in:
Sahil Batra
2021-11-26 14:59:05 +05:30
committed by Tim Abbott
parent 29dcbbb548
commit f49346892f
4 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/admin.js
View File

@@ -163,8 +163,8 @@ export function build_page() {
}; };
if (options.realm_logo_source !== "D" && options.realm_night_logo_source === "D") { if (options.realm_logo_source !== "D" && options.realm_night_logo_source === "D") {
// If no dark theme logo is specified but a day mode one is, // If no dark theme logo is specified but a light theme one is,
// use the day mode one. See also similar code in realm_logo.js. // use the light theme one. See also similar code in realm_logo.js.
options.realm_night_logo_url = options.realm_logo_url; options.realm_night_logo_url = options.realm_logo_url;
} }

2
static/js/copy_and_paste.js
View File

@@ -100,7 +100,7 @@ function select_div(div, selection) {
div.css({ div.css({
position: "absolute", position: "absolute",
left: "-99999px", left: "-99999px",
// Color and background is made according to "day mode" // Color and background is made according to "light theme"
// exclusively here because when copying the content // exclusively here because when copying the content
// into, say, Gmail compose box, the styles come along. // into, say, Gmail compose box, the styles come along.
// This is done to avoid copying the content with dark // This is done to avoid copying the content with dark

4
static/js/realm_logo.js
View File

@@ -69,8 +69,8 @@ export function render() {
$("#realm-day-logo-upload-widget .image-block").attr("src", page_params.realm_logo_url); $("#realm-day-logo-upload-widget .image-block").attr("src", page_params.realm_logo_url);
if (page_params.realm_night_logo_source === "D" && page_params.realm_logo_source !== "D") { if (page_params.realm_night_logo_source === "D" && page_params.realm_logo_source !== "D") {
// If no dark theme logo is uploaded but a day mode one // If no dark theme logo is uploaded but a light theme one
// is, use the day mode one; this handles the common case // is, use the light theme one; this handles the common case
// of transparent background logos that look good on both // of transparent background logos that look good on both
// night and day themes. See also similar code in admin.js. // night and day themes. See also similar code in admin.js.

2
static/js/ui_init.js
View File

@@ -439,7 +439,7 @@ export function initialize_everything() {
- I changed my 24-hour time preference. - I changed my 24-hour time preference.
- The realm admin changed who can edit topics. - The realm admin changed who can edit topics.
- The team's realm icon has changed. - The team's realm icon has changed.
- I switched from day mode to dark theme. - I switched from light theme to dark theme.
Especially for things that are settings-related, Especially for things that are settings-related,
we rarely abstract away the data from `page_params`. we rarely abstract away the data from `page_params`.