paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-24 08:33:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Remove unused "saved" state in save discard widget.

Browse Source
This commit is contained in:
Sayam Samal
2025-04-04 21:49:57 +05:30
committed by Tim Abbott
parent fbd28f1349
commit f496bd6350
2 changed files with 0 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/settings_components.ts
View File

@@ -574,10 +574,6 @@ export function change_save_button_state($element: JQuery, state: string): void
$element.find(".discard-button").show(); $element.find(".discard-button").show();
break; break;
case "saved":
data_status = "";
is_show = false;
break;
case "saving": case "saving":
// We don't change the button text on the saving // We don't change the button text on the saving
// state to avoid changing the button size while // state to avoid changing the button size while

6
web/tests/settings_org.test.cjs
View File

@@ -188,12 +188,6 @@ function test_change_save_button_state() {
settings_components.change_save_button_state($save_button_controls, "discarded"); settings_components.change_save_button_state($save_button_controls, "discarded");
assert.equal(props.hidden, true); assert.equal(props.hidden, true);
} }
{
settings_components.change_save_button_state($save_button_controls, "saved");
assert.equal($save_button_text.text(), "translated: Save changes");
assert.equal(props.hidden, true);
assert.equal($save_button.attr("data-status"), "");
}
{ {
settings_components.change_save_button_state($save_button_controls, "saving"); settings_components.change_save_button_state($save_button_controls, "saving");
assert.equal($save_button.attr("data-status"), "saving"); assert.equal($save_button.attr("data-status"), "saving");