paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

hotkeys: Add '>' as a hotkey for quote and reply to message.

Browse Source 
Tweaked by tabbott to fix a few minor issues.

Fixes #8146.
This commit is contained in:
Balaji2198
2018-01-31 08:53:02 +05:30
committed by Tim Abbott
parent 79e731ec50
commit f49d9d016f
8 changed files with 40 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
frontend_tests/node_tests/hotkey.js
View File

@@ -236,7 +236,7 @@ function stubbing(func_name_to_stub, test_function) {
assert_mapping('d', 'drafts.launch');
// Next, test keys that only work on a selected message.
var message_view_only_keys = '@*+RjJkKsSuvi:GM';
var message_view_only_keys = '@*+>RjJkKsSuvi:GM';
// Check that they do nothing without a selected message
global.current_msg_list.empty = return_true;
@@ -246,7 +246,7 @@ function stubbing(func_name_to_stub, test_function) {
// Check that they do nothing while in the settings overlay
overlays.settings_open = return_true;
assert_unmapped('@*+-rRjJkKsSuvi:GM');
assert_unmapped('@*+->rRjJkKsSuvi:GM');
overlays.settings_open = return_false;
// TODO: Similar check for being in the subs page
@@ -266,6 +266,7 @@ function stubbing(func_name_to_stub, test_function) {
assert_mapping('u', 'popovers.show_sender_info');
assert_mapping('i', 'popovers.open_message_menu');
assert_mapping(':', 'reactions.open_reactions_popover', true);
assert_mapping('>', 'compose_actions.quote_and_reply');
overlays.is_active = return_true;
overlays.lightbox_open = return_true;