paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-16 20:02:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

message_lists: Remove duplicate MessageContainer type.

Browse Source 
Note that the `MessageContainer` type in `compose_fade` doesn't
include the `url` property, but I haven't encountered a need for
this property during the work to convert `message_list_view` to
typescript, so it seems fine to remove it here.
This commit is contained in:
evykassirer
2024-09-09 10:46:10 -07:00
committed by Tim Abbott
parent c02f4ff941
commit f57221e78d
2 changed files with 2 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/compose_fade.ts
View File

@@ -14,7 +14,7 @@ import type {AllVisibilityPolicies} from "./user_topics";
import * as util from "./util";
// TODO/TypeScript: Move this to message_list_view.js when it's migrated to TypeScript.
type MessageContainer = {
export type MessageContainer = {
background_color: string;
date_divider_html?: string;
edited_alongside_sender: boolean;

9
web/src/message_lists.ts
View File

@@ -1,19 +1,12 @@
import $ from "jquery";
import type {MessageContainer} from "./compose_fade";
import * as inbox_util from "./inbox_util";
import type {MessageListData} from "./message_list_data";
import * as message_list_data_cache from "./message_list_data_cache";
import type {Message} from "./message_store";
import * as ui_util from "./ui_util";
// TODO(typescript): Move this to message_list_view when it's
// converted to TypeScript.
export type MessageContainer = {
msg: Message;
is_hidden: boolean;
url: string;
};
// TODO(typescript): Move this to message_list_view when it's
// converted to typescript.
type MessageListView = {