From f6edaaab96ec7ab7c903429f6aa56355cca8aa1f Mon Sep 17 00:00:00 2001
From: Steve Howell <showell@zulip.com>
Date: Fri, 5 Mar 2021 16:27:53 +0000
Subject: [PATCH] node tests: Test upload.feature_check directly.

---
 frontend_tests/node_tests/upload.js | 13 +++++++++++++
 static/js/upload.js                 |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/frontend_tests/node_tests/upload.js b/frontend_tests/node_tests/upload.js
index 9b001d527d..fb2b996c58 100644
--- a/frontend_tests/node_tests/upload.js
+++ b/frontend_tests/node_tests/upload.js
@@ -35,6 +35,19 @@ const plugin_stub = {
 
 let upload = zrequire("upload");
 
+run_test("feature_check", (override) => {
+    const upload_button = $.create("upload-button-stub");
+    upload_button.addClass("notdisplayed");
+    upload.feature_check(upload_button);
+    assert(upload_button.hasClass("notdisplayed"));
+
+    override(window, "XMLHttpRequest", function () {
+        return {upload: true};
+    });
+    upload.feature_check(upload_button);
+    assert(!upload_button.hasClass("notdisplayed"));
+});
+
 run_test("make_upload_absolute", () => {
     let uri = "/user_uploads/5/d4/6lSlfIPIg9nDI2Upj0Mq_EbE/kerala.png";
     const expected_uri = "https://foo.com/user_uploads/5/d4/6lSlfIPIg9nDI2Upj0Mq_EbE/kerala.png";
diff --git a/static/js/upload.js b/static/js/upload.js
index a52e8ac4dd..b1d5115841 100644
--- a/static/js/upload.js
+++ b/static/js/upload.js
@@ -17,7 +17,7 @@ export function make_upload_absolute(uri) {
 
 // Show the upload button only if the browser supports it.
 export function feature_check(upload_button) {
-    if (window.XMLHttpRequest && new XMLHttpRequest().upload) {
+    if (window.XMLHttpRequest && new window.XMLHttpRequest().upload) {
         upload_button.removeClass("notdisplayed");
     }
 }