paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

custom_profile_fields: Add "required" parameter to the profile fields.

Browse Source 
Fixes #28512.
This commit is contained in:
Vector73
2024-03-19 18:52:03 +05:30
committed by Tim Abbott
parent ac0673e0b5
commit f758ca596b
31 changed files with 281 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
zerver/tests/test_custom_profile_data.py
View File

@@ -482,6 +482,7 @@ class UpdateCustomProfileFieldTest(CustomProfileFieldTestCase):
self.assertEqual(field.name, "New phone number")
self.assertIs(field.hint, "")
self.assertEqual(field.field_type, CustomProfileField.SHORT_TEXT)
self.assertEqual(field.required, False)
result = self.client_patch(
f"/json/realm/profile_fields/{field.id}",
@@ -511,12 +512,24 @@ class UpdateCustomProfileFieldTest(CustomProfileFieldTestCase):
msg = 'Argument "display_in_profile_summary" is not valid JSON.'
self.assert_json_error(result, msg)
result = self.client_patch(
f"/json/realm/profile_fields/{field.id}",
info={
"name": "New phone number",
"hint": "New contact number",
"required": "invalid value",
},
)
msg = 'Argument "required" is not valid JSON.'
self.assert_json_error(result, msg)
result = self.client_patch(
f"/json/realm/profile_fields/{field.id}",
info={
"name": "New phone number",
"hint": "New contact number",
"display_in_profile_summary": "true",
"required": "true",
},
)
self.assert_json_success(result)
@@ -527,6 +540,7 @@ class UpdateCustomProfileFieldTest(CustomProfileFieldTestCase):
self.assertEqual(field.hint, "New contact number")
self.assertEqual(field.field_type, CustomProfileField.SHORT_TEXT)
self.assertEqual(field.display_in_profile_summary, True)
self.assertEqual(field.required, True)
result = self.client_patch(
f"/json/realm/profile_fields/{field.id}",