paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 21:13:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

channel_settings: Improve clarity of subscription result message.

Browse Source 
The result message shown when adding members to a stream
previously listed the name of every member being added,
which could be noisy for large groups.

This commit updates stream_subscription_request_result.hbs to
conditionally display clearer, more concise messages based
on the number of subscribed and already subscribed users.

This improves readability and user experience when handling
large subscription actions.

Fixes part of #34347

Co-authored-by: Rajeev Tapadia <108951750+rajeevtapadia@users.noreply.github.com>
Signed-off-by: apoorvapendse <apoorvavpendse@gmail.com>
This commit is contained in:
Apoorva Pendse
2025-04-15 14:32:16 +05:30
committed by Tim Abbott
parent 5288631514
commit f75fbdda8b
4 changed files with 134 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/templates/stream_settings/stream_members.hbs
View File

@@ -5,8 +5,8 @@
</h4>
<div class="subscriber_list_settings">
<div class="subscriber_list_add float-left">
{{> add_subscribers_form .}}
<div class="stream_subscription_request_result"></div>
{{> add_subscribers_form .}}
</div>
<div class="clear-float"></div>
</div>

63
web/templates/stream_settings/stream_subscription_request_result.hbs
View File

@@ -1,26 +1,43 @@
{{#if message}}
{{message}}
<br />
{{/if}}
{{#if subscribed_users}}
{{#if subscribed_users.[1]}}
{{t "Successfully subscribed users:" }}
{{else}}
{{t "Successfully subscribed user:" }}
{{/if}}
{{#each subscribed_users}}
<a data-user-id="{{user_id}}" class="view_user_profile">{{full_name}}</a>{{#unless @last}},{{else}}.{{/unless}}
{{/each}}
<br />
{{/if}}
{{#if already_subscribed_users}}
{{#each already_subscribed_users}}
{{#if @first}}
{{t "Already subscribed users:" }}
{{/if}}
<a data-user-id="{{user_id}}" class="view_user_profile">{{full_name}}</a>{{#unless @last}},{{else}}.{{/unless}}
{{/each}}
<br />
{{#if error_message}}
<div class="banner-wrapper">
<div class="banner banner-danger">
<span class="banner-label">
{{error_message}}
</span>
</div>
</div>
{{else}}
<div class="banner-wrapper">
<div class="banner banner-success">
<span class="banner-label">
{{#if (eq subscribed_users_count 0)}}
{{t "All users were already subscribed."}}
{{else}}
{{#if (not is_total_subscriber_more_than_five) }}
{{#if subscribed_users}}
{{t "Subscribed:" }} {{{subscribe_success_messages.subscribed_users_message}}}.
{{/if}}
{{#if already_subscribed_users}}
{{t "Already a subscriber:" }} {{{subscribe_success_messages.already_subscribed_users_message}}}.
{{/if}}
{{else}}
{{#if subscribed_users}}
{{t "{subscribed_users_count, plural,
one {Subscribed: {subscribed_users_count} user.}
other {Subscribed: {subscribed_users_count} users.}
}"}}
{{/if}}
{{#if already_subscribed_users}}
{{t "{already_subscribed_users_count, plural,
one {Already subscribed: {already_subscribed_users_count} user.}
other {Already subscribed: {already_subscribed_users_count} users.}
}"}}
{{/if}}
{{/if}}
{{/if}}
</span>
</div>
</div>
{{/if}}
{{#if ignored_deactivated_users}}
{{#each ignored_deactivated_users}}