paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-23 07:52:35 +00:00
Code Issues Packages Projects Releases Wiki Activity

scheduled_messages_overlay_ui: Refactor function to not mutate object.

Browse Source 
Instead of mutating `message_render_context` object with fields,
we declare the object once depending on msg_type. This is a
prep-commit for migrating the module to TS.
This commit is contained in:
Varun Singh
2024-10-21 02:55:03 +05:30
committed by Tim Abbott
parent 5816dda2c9
commit f7f6f8703e
1 changed files with 27 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
web/src/scheduled_messages_overlay_ui.js
View File

@@ -64,23 +64,34 @@ function format(scheduled_messages) {
const formatted_msgs = []; const formatted_msgs = [];
const sorted_messages = sort_scheduled_messages(scheduled_messages); const sorted_messages = sort_scheduled_messages(scheduled_messages);
for (const msg of sorted_messages) { for (const msg of sorted_messages) {
const msg_render_context = {...msg}; let msg_render_context;
if (msg.type === "stream") {
msg_render_context.is_stream = true;
msg_render_context.stream_id = msg.to;
msg_render_context.stream_name = sub_store.maybe_get_stream_name(
msg_render_context.stream_id,
);
const color = stream_data.get_color(msg_render_context.stream_id);
msg_render_context.recipient_bar_color = stream_color.get_recipient_bar_color(color);
msg_render_context.stream_privacy_icon_color =
stream_color.get_stream_privacy_icon_color(color);
} else {
msg_render_context.is_stream = false;
msg_render_context.recipients = people.get_recipients(msg.to.join(","));
}
const time = new Date(msg.scheduled_delivery_timestamp * 1000); const time = new Date(msg.scheduled_delivery_timestamp * 1000);
msg_render_context.formatted_send_at_time = timerender.get_full_datetime(time, "time"); const formatted_send_at_time = timerender.get_full_datetime(time, "time");
if (msg.type === "stream") {
const stream_id = msg.to;
const stream_name = sub_store.maybe_get_stream_name(stream_id);
const color = stream_data.get_color(stream_id);
const recipient_bar_color = stream_color.get_recipient_bar_color(color);
const stream_privacy_icon_color = stream_color.get_stream_privacy_icon_color(color);
msg_render_context = {
...msg,
is_stream: true,
stream_id,
stream_name,
recipient_bar_color,
stream_privacy_icon_color,
formatted_send_at_time,
};
} else {
const recipients = people.get_recipients(msg.to.join(","));
msg_render_context = {
...msg,
is_stream: false,
recipients,
formatted_send_at_time,
};
}
formatted_msgs.push(msg_render_context); formatted_msgs.push(msg_render_context);
} }
return formatted_msgs; return formatted_msgs;