paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

settings: Remove save changes button from "UI settings" section.

Browse Source 
Fixes: #6330.
This commit is contained in:
Anupam-dagar
2017-09-09 20:38:13 +00:00
committed by Tim Abbott
parent 63bbbba5aa
commit f82c5e9626
2 changed files with 24 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
static/js/settings_lab.js
View File

@@ -5,35 +5,34 @@ var exports = {};
exports.set_up = function () { exports.set_up = function () {
$("#ui-settings-status").hide(); $("#ui-settings-status").hide();
$("#ui-settings").on("click", "input[name='change_settings']", function (e) { $("#ui-settings .change-setting").change(function (e) {
e.preventDefault(); e.preventDefault();
var labs_updates = {}; var labs_updates = {};
_.each(["autoscroll_forever", "default_desktop_notifications"], _.each(["autoscroll_forever", "default_desktop_notifications"],
function (setting) { function (setting) {
labs_updates[setting] = $("#" + setting).is(":checked"); labs_updates[setting] = $("#" + setting).is(":checked");
});
channel.patch({
url: '/json/settings/ui',
data: labs_updates,
success: function (resp, statusText, xhr) {
var message = i18n.t("Updated settings! You will need to reload for these changes to take effect.", page_params);
var result = JSON.parse(xhr.responseText);
var ui_settings_status = $('#ui-settings-status').expectOne();
if (result.autoscroll_forever !== undefined) {
page_params.autoscroll_forever = result.autoscroll_forever;
resize.resize_page_components();
}
ui_report.success(message, ui_settings_status);
},
error: function (xhr) {
ui_report.error(i18n.t("Error changing settings"), xhr, $('#ui-settings-status').expectOne());
},
});
}); });
channel.patch({
url: '/json/settings/ui',
data: labs_updates,
success: function (resp, statusText, xhr) {
var message = i18n.t("Updated settings! You will need to reload for these changes to take effect.", page_params);
var result = JSON.parse(xhr.responseText);
var ui_settings_status = $('#ui-settings-status').expectOne();
if (result.autoscroll_forever !== undefined) {
page_params.autoscroll_forever = result.autoscroll_forever;
resize.resize_page_components();
}
ui_report.success(message, ui_settings_status);
},
error: function (xhr) {
ui_report.error(i18n.t("Error changing settings"), xhr, $('#ui-settings-status').expectOne());
},
});
});
}; };
return exports; return exports;

10
static/templates/settings/ui-settings.handlebars
View File

@@ -8,7 +8,7 @@
<div class="side-padded-container"> <div class="side-padded-container">
<div class="input-group"> <div class="input-group">
<label class="checkbox"> <label class="checkbox">
<input type="checkbox" class="inline-block" name="autoscroll_forever" id="autoscroll_forever" <input type="checkbox" class="inline-block change-setting" name="autoscroll_forever" id="autoscroll_forever"
{{#if page_params.autoscroll_forever}} {{#if page_params.autoscroll_forever}}
checked="checked" checked="checked"
{{/if}} /> {{/if}} />
@@ -20,7 +20,7 @@
</div> </div>
<div class="input-group"> <div class="input-group">
<label class="checkbox"> <label class="checkbox">
<input type="checkbox" class="inline-block" name="default_desktop_notifications" id="default_desktop_notifications" <input type="checkbox" class="inline-block change-setting" name="default_desktop_notifications" id="default_desktop_notifications"
{{#if page_params.default_desktop_notifications}} {{#if page_params.default_desktop_notifications}}
checked="checked" checked="checked"
{{/if}} /> {{/if}} />
@@ -31,11 +31,5 @@
</label> </label>
</div> </div>
</div> </div>
<div class="input-group no-border">
<div class="ui-submission">
<input type="submit" name="change_settings" value="{{t 'Save changes' }}" class="button rounded sea-green" />
</div>
</div>
</form> </form>
</div> </div>