paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 22:13:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

js: Prefix jQuery object variable names with $.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2022-01-25 02:36:19 -08:00
parent f21842e920
commit f84a2c08d5
195 changed files with 4883 additions and 4835 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
static/js/compose_validate.js
View File

@@ -106,12 +106,12 @@ export function warn_if_private_stream_is_linked(linked_stream) {
const stream_name = linked_stream.name;
const warning_area = $("#compose_private_stream_alert");
const $warning_area = $("#compose_private_stream_alert");
const context = {stream_name};
const new_row = render_compose_private_stream_alert(context);
warning_area.append(new_row);
warning_area.show();
$warning_area.append(new_row);
$warning_area.show();
}
export function warn_if_mentioning_unsubscribed_user(mentioned) {
@@ -143,10 +143,10 @@ export function warn_if_mentioning_unsubscribed_user(mentioned) {
}
if (needs_subscribe_warning(user_id, sub.stream_id)) {
const error_area = $("#compose_invite_users");
const existing_invites_area = $("#compose_invite_users .compose_invite_user");
const $error_area = $("#compose_invite_users");
const $existing_invites_area = $("#compose_invite_users .compose_invite_user");
const existing_invites = Array.from($(existing_invites_area), (user_row) =>
const existing_invites = Array.from($($existing_invites_area), (user_row) =>
Number.parseInt($(user_row).data("user-id"), 10),
);
@@ -159,10 +159,10 @@ export function warn_if_mentioning_unsubscribed_user(mentioned) {
};
const new_row = render_compose_invite_users(context);
error_area.append(new_row);
$error_area.append(new_row);
}
error_area.show();
$error_area.show();
}
}
@@ -224,14 +224,14 @@ function show_all_everyone_warnings(stream_id) {
count: stream_count,
mention: wildcard_mention,
});
const error_area_all_everyone = $("#compose-all-everyone");
const $error_area_all_everyone = $("#compose-all-everyone");
// only show one error for any number of @all or @everyone mentions
if (!error_area_all_everyone.is(":visible")) {
error_area_all_everyone.append(all_everyone_template);
if (!$error_area_all_everyone.is(":visible")) {
$error_area_all_everyone.append(all_everyone_template);
}
error_area_all_everyone.show();
$error_area_all_everyone.show();
user_acknowledged_all_everyone = false;
}
@@ -245,13 +245,13 @@ function show_announce_warnings(stream_id) {
const stream_count = peer_data.get_subscriber_count(stream_id) || 0;
const announce_template = render_compose_announce({count: stream_count});
const error_area_announce = $("#compose-announce");
const $error_area_announce = $("#compose-announce");
if (!error_area_announce.is(":visible")) {
error_area_announce.append(announce_template);
if (!$error_area_announce.is(":visible")) {
$error_area_announce.append(announce_template);
}
error_area_announce.show();
$error_area_announce.show();
user_acknowledged_announce = false;
}
@@ -660,12 +660,12 @@ export function check_overflow_text() {
// expensive.
const text = compose_state.message_content();
const max_length = page_params.max_message_length;
const indicator = $("#compose_limit_indicator");
const $indicator = $("#compose_limit_indicator");
if (text.length > max_length) {
indicator.addClass("over_limit");
$indicator.addClass("over_limit");
$("#compose-textarea").addClass("over_limit");
indicator.text(text.length + "/" + max_length);
$indicator.text(text.length + "/" + max_length);
compose_error.show(
$t_html(
{
@@ -677,16 +677,16 @@ export function check_overflow_text() {
);
$("#compose-send-button").prop("disabled", true);
} else if (text.length > 0.9 * max_length) {
indicator.removeClass("over_limit");
$indicator.removeClass("over_limit");
$("#compose-textarea").removeClass("over_limit");
indicator.text(text.length + "/" + max_length);
$indicator.text(text.length + "/" + max_length);
$("#compose-send-button").prop("disabled", false);
if ($("#compose-send-status").hasClass("alert-error")) {
$("#compose-send-status").stop(true).fadeOut();
}
} else {
indicator.text("");
$indicator.text("");
$("#compose-textarea").removeClass("over_limit");
$("#compose-send-button").prop("disabled", false);