paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 23:13:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

js: Prefix jQuery object variable names with $.

Browse Source 
Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2022-01-25 02:36:19 -08:00
parent f21842e920
commit f84a2c08d5
195 changed files with 4883 additions and 4835 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
static/js/widgetize.js
View File

@@ -19,16 +19,16 @@ export function clear_for_testing() {
widget_contents.clear();
}
function set_widget_in_message(row, widget_elem) {
const content_holder = row.find(".message_content");
function set_widget_in_message($row, $widget_elem) {
const $content_holder = $row.find(".message_content");
// Avoid adding the widget_elem if it already exists.
// Avoid adding the $widget_elem if it already exists.
// This can happen when the app loads in the "Recent topics"
// view and the user changes the view to "All messages".
// This is important since jQuery removes all the event handlers
// on `empty()`ing an element.
if (content_holder.find(".widget-content").length === 0) {
content_holder.empty().append(widget_elem);
if ($content_holder.find(".widget-content").length === 0) {
$content_holder.empty().append($widget_elem);
}
}
@@ -36,7 +36,7 @@ export function activate(in_opts) {
const widget_type = in_opts.widget_type;
const extra_data = in_opts.extra_data;
const events = in_opts.events;
const row = in_opts.row;
const $row = in_opts.$row;
const message = in_opts.message;
const post_to_server = in_opts.post_to_server;
@@ -57,53 +57,53 @@ export function activate(in_opts) {
});
};
if (row.attr("id").startsWith("zhome") && narrow_state.active()) {
if ($row.attr("id").startsWith("zhome") && narrow_state.active()) {
// Don't place widget in a home message row if we are narrowed
// to active state
return;
}
let widget_elem = widget_contents.get(message.id);
if (widget_elem) {
set_widget_in_message(row, widget_elem);
let $widget_elem = widget_contents.get(message.id);
if ($widget_elem) {
set_widget_in_message($row, $widget_elem);
return;
}
// We depend on our widgets to use templates to build
// the HTML that will eventually go in this div.
widget_elem = $("<div>").addClass("widget-content");
$widget_elem = $("<div>").addClass("widget-content");
widgets.get(widget_type).activate({
elem: widget_elem,
$elem: $widget_elem,
callback,
message,
extra_data,
});
widget_contents.set(message.id, widget_elem);
set_widget_in_message(row, widget_elem);
widget_contents.set(message.id, $widget_elem);
set_widget_in_message($row, $widget_elem);
// Replay any events that already happened. (This is common
// when you narrow to a message after other users have already
// interacted with it.)
if (events.length > 0) {
widget_elem.handle_events(events);
$widget_elem.handle_events(events);
}
}
export function set_widgets_for_list() {
for (const [idx, widget_elem] of widget_contents) {
for (const [idx, $widget_elem] of widget_contents) {
if (message_lists.current.get(idx) !== undefined) {
const row = message_lists.current.get_row(idx);
set_widget_in_message(row, widget_elem);
const $row = message_lists.current.get_row(idx);
set_widget_in_message($row, $widget_elem);
}
}
}
export function handle_event(widget_event) {
const widget_elem = widget_contents.get(widget_event.message_id);
const $widget_elem = widget_contents.get(widget_event.message_id);
if (!widget_elem) {
if (!$widget_elem) {
// It is common for submessage events to arrive on
// messages that we don't yet have in view. We
// just ignore them completely here.
@@ -112,5 +112,5 @@ export function handle_event(widget_event) {
const events = [widget_event];
widget_elem.handle_events(events);
$widget_elem.handle_events(events);
}