paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-10-27 18:13:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

mypy: Improve type checks for user display recipients.

Browse Source
This commit is contained in:
Steve Howell
2023-08-10 14:12:37 +00:00
committed by Tim Abbott
parent 1b7880fc21
commit f8ec00b895
6 changed files with 17 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
zerver/lib/email_notifications.py
View File

@@ -269,7 +269,6 @@ def build_message_list(
elif message.recipient.type == Recipient.HUDDLE:
grouping = {"huddle": message.recipient_id}
display_recipient = get_display_recipient(message.recipient)
assert not isinstance(display_recipient, str)
narrow_link = huddle_narrow_url(
user=user,
display_recipient=display_recipient,
@@ -475,8 +474,6 @@ def do_send_missedmessage_events_reply_in_zulip(
senders = list({m["message"].sender for m in missed_messages})
if missed_messages[0]["message"].recipient.type == Recipient.HUDDLE:
display_recipient = get_display_recipient(missed_messages[0]["message"].recipient)
# Make sure that this is a list of strings, not a string.
assert not isinstance(display_recipient, str)
narrow_url = huddle_narrow_url(
user=user_profile,
display_recipient=display_recipient,