paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-07 07:23:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

hotkeys: Remove typeahead logic for escape keys.

Browse Source 
We had some ancient logic for typeaheads that was supposed to be
Firefox-specific, but I can't reproduce the code even running under
Firefox, and even if it did, it was returning true instead of false
for a long time, so I suspect the code has been wrong/irrelevant for
a long time.
This commit is contained in:
Steve Howell
2017-03-12 11:13:48 -07:00
committed by Tim Abbott
parent 55ade83ac2
commit f9d26856e8
1 changed files with 0 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
static/js/hotkey.js
View File

@@ -168,20 +168,6 @@ exports.process_escape_key = function (e) {
} }
if (exports.processing_text()) { if (exports.processing_text()) {
// If one of our typeaheads is open, do nothing so that the Esc
// will go to close it
if ($("#subject").data().typeahead.shown ||
$("#stream").data().typeahead.shown ||
$("#private_message_recipient").data().typeahead.shown ||
$("#new_message_content").data().typeahead.shown ||
$("#search_query").data().typeahead.shown) {
// For some reason this code is only needed in Firefox;
// in Chrome our typeahead is able to intercept the Esc
// event before we even get it.
// Regardless, we do nothing in this case.
return true;
}
if ($(".message_edit_content").filter(":focus").length > 0) { if ($(".message_edit_content").filter(":focus").length > 0) {
row = $(".message_edit_content").filter(":focus").closest(".message_row"); row = $(".message_edit_content").filter(":focus").closest(".message_row");
message_edit.end(row); message_edit.end(row);