paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-02 04:53:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

js: Automatically convert var to let and const in more files.

Browse Source 
This commit was automatically generated by `tools/lint --only=eslint
--fix`, after an `.eslintrc.json` change.

A half dozen files were removed from the changes by tabbott pending
further work to ensure we avoid breaking valuable PRs with merge
conflicts.

Signed-off-by: Anders Kaseorg <anders@zulipchat.com>
This commit is contained in:
Anders Kaseorg
2019-11-01 16:06:25 -07:00
parent 329d0126bd
commit f9f104a4f8
18 changed files with 904 additions and 904 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
frontend_tests/node_tests/markdown.js
View File

@@ -48,16 +48,16 @@ set_global('Image', function () {
});
emoji.initialize();
var doc = "";
const doc = "";
set_global('document', doc);
set_global('$', global.make_zjquery());
set_global('feature_flags', {local_echo: true});
var people = global.people;
const people = global.people;
var cordelia = {
const cordelia = {
full_name: 'Cordelia Lear',
user_id: 101,
email: 'cordelia@zulip.com',
@@ -96,21 +96,21 @@ people.add({
people.initialize_current_user(cordelia.user_id);
var hamletcharacters = {
const hamletcharacters = {
name: "hamletcharacters",
id: 1,
description: "Characters of Hamlet",
members: [cordelia.user_id],
};
var backend = {
const backend = {
name: "Backend",
id: 2,
description: "Backend team",
members: [],
};
var edgecase_group = {
const edgecase_group = {
name: "Bobby <h1>Tables</h1>",
id: 3,
description: "HTML Syntax to check for Markdown edge cases.",
@@ -121,15 +121,15 @@ global.user_groups.add(hamletcharacters);
global.user_groups.add(backend);
global.user_groups.add(edgecase_group);
var stream_data = global.stream_data;
var denmark = {
const stream_data = global.stream_data;
const denmark = {
subscribed: false,
color: 'blue',
name: 'Denmark',
stream_id: 1,
is_muted: true,
};
var social = {
const social = {
subscribed: true,
color: 'red',
name: 'social',
@@ -137,14 +137,14 @@ var social = {
is_muted: false,
invite_only: true,
};
var edgecase_stream = {
const edgecase_stream = {
subscribed: true,
color: 'green',
name: 'Bobby <h1>Tables</h1>',
stream_id: 3,
is_muted: false,
};
var edgecase_stream_2 = {
const edgecase_stream_2 = {
subscribed: true,
color: 'yellow',
name: 'Bobby <h1',
@@ -161,18 +161,18 @@ stream_data.add_sub('Bobby <h1', edgecase_stream_2);
// Check the default behavior of fenced code blocks
// works properly before markdown is initialized.
run_test('fenced_block_defaults', () => {
var input = '\n```\nfenced code\n```\n\nand then after\n';
var expected = '\n\n<div class="codehilite"><pre><span></span>fenced code\n</pre></div>\n\n\n\nand then after\n\n';
var output = fenced_code.process_fenced_code(input);
const input = '\n```\nfenced code\n```\n\nand then after\n';
const expected = '\n\n<div class="codehilite"><pre><span></span>fenced code\n</pre></div>\n\n\n\nand then after\n\n';
const output = fenced_code.process_fenced_code(input);
assert.equal(output, expected);
});
markdown.initialize();
var bugdown_data = global.read_fixture_data('markdown_test_cases.json');
const bugdown_data = global.read_fixture_data('markdown_test_cases.json');
run_test('bugdown_detection', () => {
var no_markup = [
const no_markup = [
"This is a plaintext message",
"This is a plaintext: message",
"This is a :plaintext message",
@@ -195,7 +195,7 @@ run_test('bugdown_detection', () => {
"And an avatar !avatar(leo@zulip.com) is here",
];
var markup = [
const markup = [
"Contains a https://zulip.com/image.png file",
"Contains a https://zulip.com/image.jpg file",
"https://zulip.com/image.jpg",
@@ -220,7 +220,7 @@ run_test('bugdown_detection', () => {
});
run_test('marked_shared', () => {
var tests = bugdown_data.regular_tests;
const tests = bugdown_data.regular_tests;
tests.forEach(function (test) {
@@ -229,11 +229,11 @@ run_test('marked_shared', () => {
return;
}
var message = {raw_content: test.input};
const message = {raw_content: test.input};
page_params.translate_emoticons = test.translate_emoticons || false;
markdown.apply_markdown(message);
var output = message.content;
var error_message = `Failure in test: ${test.name}`;
const output = message.content;
const error_message = `Failure in test: ${test.name}`;
if (test.marked_expected_output) {
global.bugdown_assert.notEqual(test.expected_output, output, error_message);
global.bugdown_assert.equal(test.marked_expected_output, output, error_message);
@@ -246,7 +246,7 @@ run_test('marked_shared', () => {
});
run_test('message_flags', () => {
var message = {raw_content: '@**Leo**'};
let message = {raw_content: '@**Leo**'};
markdown.apply_markdown(message);
assert(!message.mentioned);
assert(!message.mentioned_me_directly);
@@ -263,7 +263,7 @@ run_test('message_flags', () => {
});
run_test('marked', () => {
var test_cases = [
const test_cases = [
{input: 'hello', expected: '<p>hello</p>'},
{input: 'hello there', expected: '<p>hello there</p>'},
{input: 'hello **bold** for you', expected: '<p>hello <strong>bold</strong> for you</p>'},
@@ -396,18 +396,18 @@ run_test('marked', () => {
// Disable emoji conversion by default.
page_params.translate_emoticons = test_case.translate_emoticons || false;
var input = test_case.input;
var expected = test_case.expected;
const input = test_case.input;
const expected = test_case.expected;
var message = {raw_content: input};
const message = {raw_content: input};
markdown.apply_markdown(message);
var output = message.content;
const output = message.content;
assert.equal(expected, output);
});
});
run_test('topic_links', () => {
var message = {type: 'stream', topic: "No links here"};
let message = {type: 'stream', topic: "No links here"};
markdown.add_topic_links(message);
assert.equal(util.get_topic_links(message).length, []);
@@ -456,8 +456,8 @@ run_test('topic_links', () => {
});
run_test('message_flags', () => {
var input = "/me is testing this";
var message = {topic: "No links here", raw_content: input};
let input = "/me is testing this";
let message = {topic: "No links here", raw_content: input};
markdown.apply_markdown(message);
assert.equal(message.is_me_message, true);
@@ -528,7 +528,7 @@ run_test('message_flags', () => {
});
run_test('backend_only_realm_filters', () => {
var backend_only_realm_filters = [
const backend_only_realm_filters = [
'Here is the PR-#123.',
'Function abc() was introduced in (PR)#123.',
];
@@ -541,8 +541,8 @@ run_test('python_to_js_filter', () => {
// The only way to reach python_to_js_filter is indirectly, hence the call
// to set_realm_filters.
markdown.set_realm_filters([['/a(?im)a/g'], ['/a(?L)a/g']]);
var actual_value = marked.InlineLexer.rules.zulip.realm_filters;
var expected_value = [/\/aa\/g(?![\w])/gim, /\/aa\/g(?![\w])/g];
let actual_value = marked.InlineLexer.rules.zulip.realm_filters;
let expected_value = [/\/aa\/g(?![\w])/gim, /\/aa\/g(?![\w])/g];
assert.deepEqual(actual_value, expected_value);
// Test case with multiple replacements.
markdown.set_realm_filters([['#cf(?P<contest>[0-9]+)(?P<problem>[A-Z][0-9A-Z]*)', 'http://google.com']]);
@@ -562,7 +562,7 @@ run_test('python_to_js_filter', () => {
run_test('katex_throws_unexpected_exceptions', () => {
katex.renderToString = function () { throw new Error('some-exception'); };
blueslip.set_test_data('error', 'Error: some-exception');
var message = { raw_content: '$$a$$' };
const message = { raw_content: '$$a$$' };
markdown.apply_markdown(message);
assert.equal(blueslip.get_test_logs('error').length, 1);
blueslip.clear_test_data();