paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-03 21:43:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

left_sidebar: Prevent left_sidebar to auto hide on clicking popovers.

Browse Source 
Previously, clicking on left_sidebar popovers on smaller screens,
where the left_sidebar is hidden by default, caused the left_sidebar
to close automatically. This required users to repeatedly reopen
the sidebar if they wanted to perform multiple actions on the popover.

This commit resolves the issue by adding the
no-auto-hide-left-sidebar-overlay class to the left_sidebar popovers.

Fixes: #27625
This commit is contained in:
Sourabh Patel
2025-01-20 16:31:33 +05:30
committed by Tim Abbott
parent a7ab90bf69
commit fa1f911c5d
7 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
web/templates/popovers/color_picker_popover.hbs
View File

@@ -1,4 +1,4 @@
<div class="popover-menu color-picker-popover" data-simplebar data-simplebar-tab-index="-1">
<div class="popover-menu color-picker-popover no-auto-hide-left-sidebar-overlay" data-simplebar data-simplebar-tab-index="-1">
<div class="message_header message_header_stream" data-stream-id="{{stream_id}}">
<div class="message-header-contents" style="background: {{recipient_bar_color}};">
<div class="message_label_clickable stream_label">

2
web/templates/popovers/left_sidebar/left_sidebar_all_messages_popover.hbs
View File

@@ -8,7 +8,7 @@
</a>
</li>
{{else}}
<li role="none" class="link-item popover-menu-list-item">
<li role="none" class="link-item popover-menu-list-item no-auto-hide-left-sidebar-overlay">
<a role="menuitem" class="set-home-view popover-menu-link" data-view-code="{{view_code}}" tabindex="0">
<i class="popover-menu-icon zulip-icon zulip-icon-house" aria-hidden="true"></i>
<span class="popover-menu-label">

2
web/templates/popovers/left_sidebar/left_sidebar_inbox_popover.hbs
View File

@@ -8,7 +8,7 @@
</a>
</li>
{{else}}
<li role="none" class="link-item popover-menu-list-item">
<li role="none" class="link-item popover-menu-list-item no-auto-hide-left-sidebar-overlay">
<a role="menuitem" class="set-home-view popover-menu-link" data-view-code="{{view_code}}" tabindex="0">
<i class="popover-menu-icon zulip-icon zulip-icon-house" aria-hidden="true"></i>
<span class="popover-menu-label">

2
web/templates/popovers/left_sidebar/left_sidebar_recent_view_popover.hbs
View File

@@ -8,7 +8,7 @@
</a>
</li>
{{else}}
<li role="none" class="link-item popover-menu-list-item">
<li role="none" class="link-item popover-menu-list-item no-auto-hide-left-sidebar-overlay">
<a role="menuitem" class="set-home-view popover-menu-link" data-view-code="{{view_code}}" tabindex="0">
<i class="popover-menu-icon zulip-icon zulip-icon-house" aria-hidden="true"></i>
<span class="popover-menu-label">

2
web/templates/popovers/left_sidebar/left_sidebar_starred_messages_popover.hbs
View File

@@ -1,4 +1,4 @@
<div class="popover-menu" data-simplebar data-simplebar-tab-index="-1">
<div class="popover-menu no-auto-hide-left-sidebar-overlay" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
{{#if show_unstar_all_button}}
<li role="none" class="link-item popover-menu-list-item">

4
web/templates/popovers/left_sidebar/left_sidebar_stream_actions_popover.hbs
View File

@@ -1,4 +1,4 @@
<div class="popover-menu" id="stream-actions-menu-popover" data-simplebar data-simplebar-tab-index="-1">
<div class="popover-menu no-auto-hide-left-sidebar-overlay" id="stream-actions-menu-popover" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list" data-stream-id="{{ stream.stream_id }}" data-name="{{ stream.name }}">
<li role="none" class="popover-stream-header text-item popover-menu-list-item">
<span class="stream-privacy-original-color-{{stream.stream_id}} stream-privacy filter-icon" style="color: {{stream.color}}">
@@ -65,7 +65,7 @@
</a>
</li>
<li role="separator" class="popover-menu-separator hidden-for-spectators"></li>
<li role="none" class="link-item popover-menu-list-item hidden-for-spectators no-auto-hide-left-sidebar-overlay">
<li role="none" class="link-item popover-menu-list-item hidden-for-spectators">
<a role="menuitem" class="choose_stream_color popover-menu-link" data-stream-id="{{ stream.stream_id }}" tabindex="0">
<i class="popover-menu-icon zulip-icon zulip-icon-pipette" aria-hidden="true"></i>
<span class="popover-menu-label">{{t "Change color"}}</span>

2
web/templates/popovers/left_sidebar/left_sidebar_topic_actions_popover.hbs
View File

@@ -1,4 +1,4 @@
<div class="popover-menu" id="topic-actions-menu-popover" data-simplebar data-simplebar-tab-index="-1">
<div class="popover-menu no-auto-hide-left-sidebar-overlay" id="topic-actions-menu-popover" data-simplebar data-simplebar-tab-index="-1">
<ul role="menu" class="popover-menu-list">
<li role="none" class="popover-topic-header text-item popover-menu-list-item">
<span class="popover-topic-name {{#if is_empty_string_topic}}empty-topic-display{{/if}}">{{topic_display_name}}</span>