paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

typeahead: Fix bug where typeahead showed momentarily on shift + tab.

Browse Source 
Break on `keyup` for case of `shift` key, instead of letting it trigger
the typeahead.

Fixes: #24152.
This commit is contained in:
Joelute
2023-03-24 00:11:17 -04:00
committed by Tim Abbott
parent 42de31c2e8
commit fa37befe3c
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
web/third/bootstrap-typeahead/typeahead.js
View File

@@ -439,7 +439,6 @@ import {get_string_diff} from "../../src/util";
, keydown: function (e) { , keydown: function (e) {
const pseudo_keycode = get_pseudo_keycode(e); const pseudo_keycode = get_pseudo_keycode(e);
if (this.trigger_selection(e)) { if (this.trigger_selection(e)) {
if (!this.shown) return;
e.preventDefault(); e.preventDefault();
this.select(e); this.select(e);
} }
@@ -474,6 +473,11 @@ import {get_string_diff} from "../../src/util";
} }
break break
// to stop typeahead from showing up momentarily
// when shift + tabbing to a field with typeahead
case 16: // shift
return
default: default:
var hideOnEmpty = false var hideOnEmpty = false
if (e.keyCode === 8 && this.options.helpOnEmptyStrings) { // backspace if (e.keyCode === 8 && this.options.helpOnEmptyStrings) { // backspace