From fa8199819c86e2e94e44f178d9e7852f26aeece2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Robert=20H=C3=B6nig?= Date: Wed, 27 Sep 2017 09:47:46 +0200 Subject: [PATCH] linter: Remove unnecessary escape sequences in custom rules. --- tools/linter_lib/custom_check.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/linter_lib/custom_check.py b/tools/linter_lib/custom_check.py index e512a870d5..52f3da6384 100644 --- a/tools/linter_lib/custom_check.py +++ b/tools/linter_lib/custom_check.py @@ -213,7 +213,7 @@ def build_custom_checkers(by_lang): 'description': 'Missing whitespace after ":"'}, {'pattern': "':\w[^']*$", 'description': 'Missing whitespace after ":"'}, - {'pattern': "^\s+[#]\w", + {'pattern': "^\s+#\w", 'strip': '\n', 'description': 'Missing whitespace after "#"'}, {'pattern': "assertEquals[(]", @@ -278,14 +278,14 @@ def build_custom_checkers(by_lang): See WRAPPER_COMMENT in test_helpers.py for details. '''}, # Directly fetching Message objects in e.g. views code is often a security bug. - {'pattern': '[^r][M]essage.objects.get', + {'pattern': '[^r]Message.objects.get', 'exclude': set(["zerver/tests", "zerver/lib/onboarding.py", "zilencer/management/commands/add_mock_conversation.py", "zerver/worker/queue_processors.py"]), 'description': 'Please use access_message() to fetch Message objects', }, - {'pattern': '[S]tream.objects.get', + {'pattern': 'Stream.objects.get', 'include_only': set(["zerver/views/"]), 'description': 'Please use access_stream_by_*() to fetch Stream objects', }, @@ -303,7 +303,7 @@ def build_custom_checkers(by_lang): ]), 'description': 'Please use access_stream_by_*() to fetch Stream objects', }, - {'pattern': '[S]tream.objects.filter', + {'pattern': 'Stream.objects.filter', 'include_only': set(["zerver/views/"]), 'description': 'Please use access_stream_by_*() to fetch Stream objects', },