paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-04 05:53:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

apps: Move id="download-android-apk" from span to a.

Browse Source 
Due to spaghetti CSS that should be fixed but isn’t fixed here, the
<span> wrapper is still needed so the hover effect is applied.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg
2021-05-05 15:30:02 -07:00
committed by Tim Abbott
parent 17d2b28085
commit fa8532d9b7
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
static/js/portico/landing-page.js
View File

@@ -111,10 +111,10 @@ const apps_events = function () {
$(".info .platform").text(version_info.alt); $(".info .platform").text(version_info.alt);
$(".info .description").text(version_info.description); $(".info .description").text(version_info.description);
$(".info .desktop-download-link").attr("href", version_info.download_link); $desktop_download_link.attr("href", version_info.download_link);
$(".download-from-google-play-store").attr("href", version_info.play_store_link); $download_from_google_play_store.attr("href", version_info.play_store_link);
$(".download-from-apple-app-store").attr("href", version_info.app_store_link); $download_from_apple_app_store.attr("href", version_info.app_store_link);
$("#download-android-apk a").attr("href", version_info.download_link); $download_android_apk.attr("href", version_info.download_link);
$(".image img").attr("src", version_info.image); $(".image img").attr("src", version_info.image);
$download_instructions.find("a").attr("href", version_info.install_guide); $download_instructions.find("a").attr("href", version_info.install_guide);

2
static/styles/portico/landing_page.css
View File

@@ -3857,7 +3857,7 @@ nav {
} }
} }
#download-android-apk a { #download-android-apk {
display: inline-block; display: inline-block;
color: hsl(0, 0%, 100%); color: hsl(0, 0%, 100%);
font-size: 13px; font-size: 13px;

2
templates/zerver/apps.html
View File

@@ -25,7 +25,7 @@
<a class="desktop-download-link no-action" hidden href=""><span class="button green">Download Zulip for <span class="platform"></span></span></a> <a class="desktop-download-link no-action" hidden href=""><span class="button green">Download Zulip for <span class="platform"></span></span></a>
<a class="download-from-google-play-store" hidden href=""><img src='/static/images/store-badges/google-play-badge.png' alt=""/></a> <a class="download-from-google-play-store" hidden href=""><img src='/static/images/store-badges/google-play-badge.png' alt=""/></a>
<a class="download-from-apple-app-store" hidden href=""><img src='/static/images/store-badges/app-store-badge.svg' alt=""/></a> <a class="download-from-apple-app-store" hidden href=""><img src='/static/images/store-badges/app-store-badge.svg' alt=""/></a>
<span id="download-android-apk" hidden><a href="https://github.com/zulip/zulip-mobile/releases/latest">or manually download APK</a></span> <span><a id="download-android-apk" hidden href="https://github.com/zulip/zulip-mobile/releases/latest">or manually download APK</a></span>
</div> </div>
</div> </div>
</div> </div>