From faa08b6000f43c230b934ef347f4df9025d5881d Mon Sep 17 00:00:00 2001 From: Sayam Samal Date: Thu, 13 Feb 2025 04:28:28 +0530 Subject: [PATCH] inline_topic_edit: Remove overflowing error text on saving empty topic. --- web/src/message_edit.ts | 8 -------- web/templates/topic_edit_form.hbs | 1 - 2 files changed, 9 deletions(-) diff --git a/web/src/message_edit.ts b/web/src/message_edit.ts index d75d7f50d5..d6c431167b 100644 --- a/web/src/message_edit.ts +++ b/web/src/message_edit.ts @@ -1011,7 +1011,6 @@ export function try_save_inline_topic_edit($row: JQuery): void { } export function do_save_inline_topic_edit($row: JQuery, message: Message, new_topic: string): void { - const msg_list = message_lists.current; show_topic_edit_spinner($row); if (message.locally_echoed) { @@ -1074,13 +1073,6 @@ export function do_save_inline_topic_edit($row: JQuery, message: Message, new_to return; } loading.destroy_indicator($spinner); - if (msg_list === message_lists.current) { - const message = channel.xhr_error_message( - $t({defaultMessage: "Error saving edit"}), - xhr, - ); - $row.find(".edit_error").text(message).css("display", "inline-block"); - } }, }); } diff --git a/web/templates/topic_edit_form.hbs b/web/templates/topic_edit_form.hbs index 28691800fd..6f96b7c926 100644 --- a/web/templates/topic_edit_form.hbs +++ b/web/templates/topic_edit_form.hbs @@ -6,6 +6,5 @@ {{#unless realm_mandatory_topics}}placeholder="{{empty_string_topic_display_name}}"{{/unless}} /> {{> components/icon_button squared=true custom_classes="topic_edit_save tippy-zulip-delayed-tooltip" icon="check" intent="brand" data-tooltip-template-id="save-button-tooltip-template" }} {{> components/icon_button squared=true custom_classes="topic_edit_cancel tippy-zulip-delayed-tooltip" icon="circle-x" intent="neutral" data-tooltip-template-id="cancel-button-tooltip-template" }} -