paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-05 22:43:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

compose: Refactor format function to return a boolean.

Browse Source 
The inline `format` function defined in `format_text` function` now
returns true if formatting was added rather than removed, else false.

This is a prep commit for the upcoming change to show typeahead on using
the code formatting button to add code formatting to any selected text.
This commit is contained in:
N-Shar-ma
2024-03-07 23:02:46 +05:30
committed by Tim Abbott
parent f800d4404e
commit fb25027cfb
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
web/src/compose_ui.ts
View File

@@ -585,7 +585,7 @@ export function format_text(
}
};
const format = (syntax_start: string, syntax_end = syntax_start): void => {
const format = (syntax_start: string, syntax_end = syntax_start): boolean => {
let linebreak_start = "";
let linebreak_end = "";
if (syntax_start.startsWith("\n")) {
@@ -606,7 +606,7 @@ export function format_text(
range.start - syntax_start.length,
range.end - syntax_start.length,
);
return;
return false;
} else if (is_inner_text_formatted(syntax_start, syntax_end)) {
// Remove syntax inside the selection, if present.
text =
@@ -620,11 +620,12 @@ export function format_text(
range.start,
range.end - syntax_start.length - syntax_end.length,
);
return;
return false;
}
// Otherwise, we don't have syntax within or around, so we add it.
wrapFieldSelection(field, syntax_start, syntax_end);
return true;
};
const format_spoiler = (): void => {