settings: Extract settings.SAVE_FRONTEND_STACKTRACES.

This commit is contained in:
Tim Abbott
2016-07-18 21:44:48 -07:00
parent 522ccf8eb2
commit fb386da552
6 changed files with 6 additions and 3 deletions

View File

@@ -168,7 +168,7 @@ function report_error(msg, stack, opts) {
} }
}); });
if (page_params.staging) { if (page_params.save_stacktraces) {
// Save the stacktrace so it can be examined even in // Save the stacktrace so it can be examined even in
// development servers. (N.B. This assumes you have set DEBUG // development servers. (N.B. This assumes you have set DEBUG
// = False on your development server, or else this code path // = False on your development server, or else this code path

View File

@@ -1798,10 +1798,10 @@ class HomeTest(AuthedTestCase):
"realm_name", "realm_name",
"realm_restricted_to_domain", "realm_restricted_to_domain",
"referrals", "referrals",
"save_stacktraces",
"share_the_love", "share_the_love",
"show_digest_email", "show_digest_email",
"sounds_enabled", "sounds_enabled",
"staging",
"stream_desktop_notifications_enabled", "stream_desktop_notifications_enabled",
"stream_sounds_enabled", "stream_sounds_enabled",
"subbed_info", "subbed_info",

View File

@@ -985,7 +985,7 @@ def home(request):
max_message_id = register_ret['max_message_id'], max_message_id = register_ret['max_message_id'],
unread_count = approximate_unread_count(user_profile), unread_count = approximate_unread_count(user_profile),
furthest_read_time = sent_time_in_epoch_seconds(latest_read), furthest_read_time = sent_time_in_epoch_seconds(latest_read),
staging = settings.ZULIP_COM_STAGING or settings.DEVELOPMENT, save_stacktraces = settings.SAVE_FRONTEND_STACKTRACES,
alert_words = register_ret['alert_words'], alert_words = register_ret['alert_words'],
muted_topics = register_ret['muted_topics'], muted_topics = register_ret['muted_topics'],
realm_filters = register_ret['realm_filters'], realm_filters = register_ret['realm_filters'],

View File

@@ -22,3 +22,4 @@ EXTRA_INSTALLED_APPS = ["zilencer", "analytics"]
CAMO_URI = '' CAMO_URI = ''
OPEN_REALM_CREATION = True OPEN_REALM_CREATION = True
SAVE_FRONTEND_STACKTRACES = True

View File

@@ -56,6 +56,7 @@ if ZULIP_COM_STAGING:
EXTERNAL_HOST = 'staging.zulip.com' EXTERNAL_HOST = 'staging.zulip.com'
STATSD_PREFIX = 'staging' STATSD_PREFIX = 'staging'
STAGING_ERROR_NOTIFICATIONS = True STAGING_ERROR_NOTIFICATIONS = True
SAVE_FRONTEND_STACKTRACES = True
else: else:
EXTERNAL_HOST = 'zulip.com' EXTERNAL_HOST = 'zulip.com'
EXTERNAL_API_PATH = 'api.zulip.com' EXTERNAL_API_PATH = 'api.zulip.com'

View File

@@ -114,6 +114,7 @@ DEFAULT_SETTINGS = {'TWITTER_CONSUMER_KEY': '',
'DROPBOX_APP_KEY': '', 'DROPBOX_APP_KEY': '',
'ERROR_REPORTING': True, 'ERROR_REPORTING': True,
'STAGING_ERROR_NOTIFICATIONS': False, 'STAGING_ERROR_NOTIFICATIONS': False,
'SAVE_FRONTEND_STACKTRACES': False,
'JWT_AUTH_KEYS': {}, 'JWT_AUTH_KEYS': {},
'NAME_CHANGES_DISABLED': False, 'NAME_CHANGES_DISABLED': False,
'DEPLOYMENT_ROLE_NAME': "", 'DEPLOYMENT_ROLE_NAME': "",