paulmataruso/zulip
1
0
Fork 0
mirror of https://github.com/zulip/zulip.git synced 2025-11-06 15:03:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

stream_color.js: Fix color picker not saving custom color.

Browse Source 
Fix a bug where the color picker reverted the custom color to the
previous one after clicking outside the popover. The bug occurred
because although there is a confirm button, the 'clickoutFiresChanges'
option was set as true, which made the frontend always send two POST
request to edit the stream and, for a reason I wasn't able to discover,
if you hit the confirm button and click outside fast enough, the change
fired by the clickout event sent the old color to the server. It was
fixed by setting the 'clickoutFiresChanges' option to false.

Fixes #15101
This commit is contained in:
João Maurício
2020-05-29 20:29:27 -03:00
committed by Tim Abbott
parent d49e880c09
commit fb6047c4ae
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
static/js/stream_color.js
View File

@@ -93,7 +93,7 @@ exports.sidebar_popover_colorpicker_options = {
};
exports.sidebar_popover_colorpicker_options_full = {
clickoutFiresChange: true,
clickoutFiresChange: false,
showPalette: true,
showInput: true,
flat: true,